Skip to content

Removed deprecated method in ChatMemory #3093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Removed deprecated method in ChatMemory #3093

wants to merge 1 commit into from

Conversation

@HyunSangHan
Copy link
Contributor

@HyunSangHan HyunSangHan commented May 11, 2025

  • Removed the get(String conversationId, int lastN) method from ChatMemory.
  • Replaced all usages with get(String conversationId) which returns the full message list.

Closes #3075

@markpollack
Copy link
Member

markpollack commented May 11, 2025

I've worked on this and in the process realized we didn't have tests for advisors.

Work is in #3096

@HyunSangHan
Copy link
Contributor Author

HyunSangHan commented May 11, 2025

@markpollack Oh, sorry! I missed to check the assignee. I'll closed this PR. Thank you for the information. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove deprecated method in ChatMemory

2 participants

@HyunSangHan @markpollack