Align JdbcChatMemoryRepositoryProperties with other modules in Spring Boot #3107
Conversation
… Boot Such as `BatchProperties.Jdbc`, `IntegrationProperties.Jdbc`, `JdbcSessionProperties` and `QuartzProperties.Jdbc` 1. Reuse Spring Boot's `DatabaseInitializationMode` 2. Allow to customize platform 3. add `OnJdbcChatMemoryRepositoryDatasourceInitializationCondition` for `JdbcChatMemoryRepositorySchemaInitializer` Signed-off-by: Yanming Zhou <[email protected]>
| package org.springframework.ai.model.chat.memory.repository.jdbc.autoconfigure; | ||
|
|
||
| import org.springframework.boot.context.properties.ConfigurationProperties; | ||
| import org.springframework.boot.sql.init.DatabaseInitializationMode; |
There was a problem hiding this comment.
We have decided that the core of Spring AI will not depend on spring boot, for the chat repository work, we created our own enum for this.
There was a problem hiding this comment.
oops, my bad, I mean thtat for the non autoconfig code.
|
|
||
| @Bean | ||
| @ConditionalOnMissingBean | ||
| @Conditional(OnJdbcChatMemoryRepositoryDatasourceInitializationCondition.class) |
There was a problem hiding this comment.
we should merge this part into main
| this.initializeSchema = initializeSchema; | ||
| } | ||
|
|
||
| public String getPlatform() { |
| mode = DatabaseInitializationMode.EMBEDDED; | ||
| } | ||
| settings.setMode(mode); | ||
| settings.setSchemaLocations(resolveSchemaLocations(dataSource, properties)); |
There was a problem hiding this comment.
I was not able to get the hsqldb autoconfiguration working with this, which is why there is all this code testing the URL. I agree this code in main needs to be improved, but without some more work on a better test that shows the hsqldb can automagically be configured, the current hack works.
There was a problem hiding this comment.
Not sure what I did wrong, as I had added all this extra code. Your PR is working, though i can't figure out what I did wrong ;)
3 participants
Such as
BatchProperties.Jdbc,IntegrationProperties.Jdbc,JdbcSessionPropertiesandQuartzProperties.JdbcDatabaseInitializationModeOnJdbcChatMemoryRepositoryDatasourceInitializationConditionforJdbcChatMemoryRepositorySchemaInitializer