Skip to content

Fix that spring.ai.mcp.server.base-url is ignored #3112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix that spring.ai.mcp.server.base-url is ignored #3112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...va/org/springframework/ai/mcp/server/autoconfigure/McpWebFluxServerAutoConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
* }</pre>
*
* @author Christian Tzolov
* @author Yanming Zhou
* @since 1.0.0
* @see McpServerProperties
* @see WebFluxSseServerTransportProvider
Expand All @@ -76,8 +77,8 @@ public class McpWebFluxServerAutoConfiguration {
public WebFluxSseServerTransportProvider webFluxTransport(ObjectProvider<ObjectMapper> objectMapperProvider,
McpServerProperties serverProperties) {
ObjectMapper objectMapper = objectMapperProvider.getIfAvailable(ObjectMapper::new);
return new WebFluxSseServerTransportProvider(objectMapper, serverProperties.getSseMessageEndpoint(),
serverProperties.getSseEndpoint());
return new WebFluxSseServerTransportProvider(objectMapper, serverProperties.getBaseUrl(),
serverProperties.getSseMessageEndpoint(), serverProperties.getSseEndpoint());
}

// Router function for SSE transport used by Spring WebFlux to start an HTTP server.
Expand Down
5 changes: 3 additions & 2 deletions ...ava/org/springframework/ai/mcp/server/autoconfigure/McpWebMvcServerAutoConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
* }</pre>
*
* @author Christian Tzolov
* @author Yanming Zhou
* @since 1.0.0
* @see McpServerProperties
* @see WebMvcSseServerTransportProvider
Expand All @@ -71,8 +72,8 @@ public class McpWebMvcServerAutoConfiguration {
public WebMvcSseServerTransportProvider webMvcSseServerTransportProvider(
ObjectProvider<ObjectMapper> objectMapperProvider, McpServerProperties serverProperties) {
ObjectMapper objectMapper = objectMapperProvider.getIfAvailable(ObjectMapper::new);
return new WebMvcSseServerTransportProvider(objectMapper, serverProperties.getSseMessageEndpoint(),
serverProperties.getSseEndpoint());
return new WebMvcSseServerTransportProvider(objectMapper, serverProperties.getBaseUrl(),
serverProperties.getSseMessageEndpoint(), serverProperties.getSseEndpoint());
}

@Bean
Expand Down
7 changes: 7 additions & 0 deletions .../org/springframework/ai/mcp/server/autoconfigure/McpWebFluxServerAutoConfigurationIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,4 +61,11 @@ void serverDisableConfiguration() {
});
}

@Test
void serverBaseUrlConfiguration() {
this.contextRunner.withPropertyValues("spring.ai.mcp.server.base-url=/test")
.run(context -> assertThat(context.getBean(WebFluxSseServerTransportProvider.class)).extracting("baseUrl")
.isEqualTo("/test"));
}

}
7 changes: 7 additions & 0 deletions ...a/org/springframework/ai/mcp/server/autoconfigure/McpWebMvcServerAutoConfigurationIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,4 +61,11 @@ void serverDisableConfiguration() {
});
}

@Test
void serverBaseUrlConfiguration() {
this.contextRunner.withPropertyValues("spring.ai.mcp.server.base-url=/test")
.run(context -> assertThat(context.getBean(WebMvcSseServerTransportProvider.class)).extracting("baseUrl")
.isEqualTo("/test"));
}

}