Skip to content

Added transaction support for saveAll in JdbcChatMemoryRepository #3158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Added transaction support for saveAll in JdbcChatMemoryRepository #3158

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
418171e
fix: Added transaction support for saveAll in JdbcChatMemoryRepository
sunyuhan1998 May 14, 2025
0a78b48
fix: Adjust the transaction implementation method in JdbcChatMemoryRe…
sunyuhan1998 May 14, 2025
8cce172
fix: Adjust the transaction implementation method in JdbcChatMemoryRe…
sunyuhan1998 May 14, 2025
a610007
fix: Adjust the transaction implementation method in JdbcChatMemoryRe…
sunyuhan1998 May 14, 2025
aefd7cf
fix: Fix format.
sunyuhan1998 May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 28 additions & 7 deletions ...ain/java/org/springframework/ai/chat/memory/repository/jdbc/JdbcChatMemoryRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,11 @@

package org.springframework.ai.chat.memory.repository.jdbc;

import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Timestamp;
import java.sql.*;
import java.time.Instant;
import java.util.ArrayList;
import java.util.List;
import java.util.Optional;
import java.util.concurrent.atomic.AtomicLong;

import org.springframework.ai.chat.memory.ChatMemoryRepository;
Expand All @@ -35,6 +33,7 @@
import org.springframework.jdbc.core.BatchPreparedStatementSetter;
import org.springframework.jdbc.core.JdbcTemplate;
import org.springframework.jdbc.core.RowMapper;
import org.springframework.jdbc.datasource.DataSourceUtils;
import org.springframework.lang.Nullable;
import org.springframework.util.Assert;

Expand Down Expand Up @@ -83,9 +82,31 @@ public void saveAll(String conversationId, List<Message> messages) {
Assert.hasText(conversationId, "conversationId cannot be null or empty");
Assert.notNull(messages, "messages cannot be null");
Assert.noNullElements(messages, "messages cannot contain null elements");
this.deleteByConversationId(conversationId);
this.jdbcTemplate.batchUpdate(dialect.getInsertMessageSql(),
new AddBatchPreparedStatement(conversationId, messages));

Connection connection = null;
Assert.notNull(jdbcTemplate.getDataSource(), "jdbcTemplate.getDataSource() cannot be null");
try {
connection = DataSourceUtils.getConnection(jdbcTemplate.getDataSource());
connection.setAutoCommit(false);
this.deleteByConversationId(conversationId);
this.jdbcTemplate.batchUpdate(dialect.getInsertMessageSql(),
new AddBatchPreparedStatement(conversationId, messages));
connection.commit();
}
catch (SQLException ex) {
try {
connection.rollback();
}
catch (SQLException e) {
throw new RuntimeException("Transaction rollback exception", e);
}
throw new RuntimeException("save messages failed", ex);
}
finally {
Optional.ofNullable(connection)
.ifPresent(conn -> DataSourceUtils.releaseConnection(conn, jdbcTemplate.getDataSource()));
}

}

@Override
Expand Down