Skip to content

Conversation

@quaff
Copy link
Contributor

@quaff quaff commented May 16, 2025

No description provided.

@markpollack
Copy link
Member

Thanks, we will address this in 1.0.x release.

@markpollack markpollack added this to the 1.0.x milestone May 16, 2025
*/
String getSelectMessagesSql();
default String getSelectMessagesSql() {
return "SELECT content, type FROM SPRING_AI_CHAT_MEMORY WHERE conversation_id = ? ORDER BY "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the table name SPRING_AI_CHAT_MEMORY is in uppercase. Is there a specific reason for this, or would it be okay to change it to lowercase (e.g., spring_ai_chat_memory) to improve readability?

@markpollack markpollack removed this from the 1.1.0.M1 milestone Sep 25, 2025
@ericbottard
Copy link
Member

After careful consideration, we've decided not to merge this PR.
Default methods are useful for expressing implementations in terms of other (abstract) methods.
This PR tries to over-generalize the concept of Dialect a bit too much (it's ok to have some repetition between implementations, and as a matter of fact if users need to customize they can (and need) to provide their own implementation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants