Fix MCP protocol, related commands cannot be executed under Windows, such as npx #3323
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unable to find relevant commands compatible with Windows Signed-off-by: twelvet <[email protected]>
Strengthen model response judgment Signed-off-by: twelvet <[email protected]>
markpollack
reviewed
Jul 17, 2025
| import java.util.HashMap; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.*; |
markpollack
reviewed
Oct 22, 2025
| if (OS_NAME.contains("win") && WIN_COMMAND.contains(command)) { | ||
| List<String> winArgs = new LinkedList<>(Arrays.asList("/c", this.command())); | ||
| winArgs.addAll(this.args); | ||
| return ServerParameters.builder("cmd.exe").args(winArgs).env(this.env()).build(); |
There was a problem hiding this comment.
I believe we need to add /c for windows and perhaps simliar -c for the unix one to be more robust. look at https://github.com/spring-attic/spring-cli/blob/efa39cd922aedcfd3b172a4bb9bfd1721c29d490/src/main/java/org/springframework/cli/command/SpecialCommands.java#L59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cannot run bat related commands such as npx properly under Windows. I hope to be able to start it more friendly, otherwise it may be troublesome or catastrophic for cross platform development, which has caused me to be unable to configure it properly. Therefore, I hope to get a fix. Thank you.