Remove redundant validation call in getToolCallbacks method #3329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sunghyuk <[email protected]>
markpollack
added
bug
Member
|
Hi @sunghyuk Thanks for the PR. But, the validation logic you removed checks for duplicate tools with the same name. Please see the test case in MethodToolCallbackProviderTests#whenMultipleToolObjectsWithSameToolNameThenThrow . Closing this PR now. But, please re-open if you have a different point of view here. Thanks! |
|
@ilayaperumalg Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove redundant
validateToolCallbacks()call as validation is already performed in the constructor