feat(chroma): improve handling and testing of complex metadata values #3332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert non-primitive metadata values to JSON strings in ChromaApi.AddEmbeddingsRequest for compatibility - Add tests to verify metadata conversion and complex metadata handling in Chroma vector store integration - Ensure OpenAiChatModel always returns annotations as a list of maps in metadata - Add test dependency on spring-ai-advisors-vector-store for advisor-related tests Signed-off-by: Christian Tzolov <[email protected]>
essien
reviewed
May 26, 2025
| assertThat(processed.get("strVal")).isInstanceOf(String.class); | ||
| assertThat(processed.get("doubleVal")).isInstanceOf(Number.class).isEqualTo(3.14); | ||
| assertThat(processed.get("listVal")).isInstanceOf(String.class).isEqualTo("[1,2,3]"); | ||
| assertThat(processed.get("mapVal")).isInstanceOf(String.class); |
There was a problem hiding this comment.
Can we also verify that the value of mapVal is what we expect it to be?
There was a problem hiding this comment.
good point. It is done
…N content in tests Signed-off-by: Christian Tzolov <[email protected]>
| .uri("/api/v2/tenants/{tenant_name}/databases/{database_name}/collections/{collection_name}/upsert", | ||
| tenantName, databaseName, collectionId) | ||
| .headers(this::httpHeaders) | ||
| // .headers(this::httpHeaders) |
There was a problem hiding this comment.
Why is this commented out?
There was a problem hiding this comment.
this is a mistake. Thanks for catching it
Signed-off-by: Christian Tzolov <[email protected]>
|
Squashed, rebased and merged as 7466cb9 |
|
Also, back-ported into 1.0.x via aba837a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BACK-PORT to 1.0.1 as well!