fix(qdrant): support Long type in payload by converting to String #3367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qdrant does not support java.lang.Long as a native payload type.
Previously, passing a Long value caused the following exception:
java.lang.IllegalArgumentException: Unsupported Qdrant value type: class java.lang.Long
at org.springframework.ai.vectorstore.qdrant.QdrantValueFactory.value(QdrantValueFactory.java:85)
at org.springframework.ai.vectorstore.qdrant.QdrantValueFactory.lambda$toValueMap$1(QdrantValueFactory.java:46)
...
To resolve this, Long values are now converted to their String representation
in QdrantValueFactory. This preserves precision and avoids serialization issues.
Signed-off-by: Solomon Hsu <[email protected]>
|
@solnone Thanks for the PR adding support for Long type |
|
@solnone Thanks for the PR! Could you add a test to verify this? |
…tring Adds a test to ensure that Long values in document metadata are safely converted to String before being stored in Qdrant. The test inserts a document with a Long-type "ref_id", performs a similarity search, and verifies that: - the result is not empty, - the retrieved "ref_id" is a String, - the value matches the original Long when parsed. Also ensures cleanup by deleting the inserted document from the store. Signed-off-by: Solomon Hsu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qdrant does not support java.lang.Long as a native payload type. Previously, passing a Long value caused the following exception:
java.lang.IllegalArgumentException: Unsupported Qdrant value type: class java.lang.Long
at org.springframework.ai.vectorstore.qdrant.QdrantValueFactory.value(QdrantValueFactory.java:85)
at org.springframework.ai.vectorstore.qdrant.QdrantValueFactory.lambda$toValueMap$1(QdrantValueFactory.java:46)
...
To resolve this, Long values are now converted to their String representation in QdrantValueFactory. This preserves precision and avoids serialization issues.
Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:
mainbranch and squash your commits