Avoid looping through all the page tree if there is no destination page #3396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: torakiki <[email protected]>
ilayaperumalg
added
bug
|
@torakiki Thanks for the PR fixing the bug. Could you check the format issue in the build failure and update the PR? |
Signed-off-by: torakiki <[email protected]>
spring-builds
pushed a commit
that referenced
this pull request
May 30, 2025
…ge (#3396) * Avoid looping through all the page tree if there is no destination page Fixes: #3396 Signed-off-by: torakiki <[email protected]> (cherry picked from commit 7c674c9)
namsoo2
pushed a commit
to namsoo2/spring-ai
that referenced
this pull request
Jun 9, 2025
…ge (spring-projects#3396) * Avoid looping through all the page tree if there is no destination page Fixes: spring-projects#3396 Auto-cherry-pick to 1.0.x Signed-off-by: torakiki <[email protected]> Signed-off-by: minsoo.nam <[email protected]>
chedim
pushed a commit
to couchbaselabs/spring-ai
that referenced
this pull request
Sep 19, 2025
…ge (spring-projects#3396) * Avoid looping through all the page tree if there is no destination page Fixes: spring-projects#3396 Auto-cherry-pick to 1.0.x Signed-off-by: torakiki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a simple null check to avoid looping through all the page tree if currentPage is null and there is nothing to be found