Resolve OpenAI ApiKey for every request as late as possible #3398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Filip Hrisafov <[email protected]>
Signed-off-by: Filip Hrisafov <[email protected]>
filiphr
force-pushed
the
open-ai-dynamic-api-key
branch
from
b86228b to
08510d6
Compare
|
@filiphr Thanks for the follow up PR! |
Signed-off-by: Filip Hrisafov <[email protected]>
filiphr
force-pushed
the
open-ai-dynamic-api-key
branch
from
4dbe8c9 to
a48e608
Compare
|
Thanks @ilayaperumalg. Should we close this PR now? |
|
Yes, I will close this PR as soon as the merge build is complete along with the back-port to 1.0.x branch |
|
The latest build was successful! Back-ported into 1.0.x as dd6c0a9 |
|
Thanks @ilayaperumalg. I was not sure about the process, but all good 😄 |
|
No problem @filiphr. Thank you for your contributions and looking forward to see more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #3364. It makes sure that the ApiKey is resolved as late as possible