Skip to content

fix for Mongo vectorStore.similaritySearch failing due to org.bson.ty… #3402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix for Mongo vectorStore.similaritySearch failing due to org.bson.ty… #3402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...c/main/java/org/springframework/ai/vectorstore/mongodb/atlas/MongoDBAtlasVectorStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ private org.bson.Document createSearchIndexDefinition() {
* @return the Spring AI Document
*/
private Document mapMongoDocument(org.bson.Document mongoDocument, float[] queryEmbedding) {
String id = mongoDocument.getString(ID_FIELD_NAME);
String id = mongoDocument.getObjectId(ID_FIELD_NAME).toHexString();
String content = mongoDocument.getString(CONTENT_FIELD_NAME);
double score = mongoDocument.getDouble(SCORE_FIELD_NAME);
Map<String, Object> metadata = mongoDocument.get(METADATA_FIELD_NAME, org.bson.Document.class);
Expand Down
24 changes: 24 additions & 0 deletions ...test/java/org/springframework/ai/vectorstore/mongodb/atlas/MongoDBAtlasVectorStoreIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,30 @@ void getNativeClientTest() {
});
}

@Test
void shouldHandleObjectIdInSearchResults() {
this.contextRunner.run(context -> {
VectorStore vectorStore = context.getBean(VectorStore.class);

Document doc1 = new Document("Test content for ObjectId handling");
Document doc2 = new Document("Another test content for ObjectId handling");
vectorStore.add(List.of(doc1, doc2));
Thread.sleep(5000);

List<Document> results = vectorStore
.similaritySearch(SearchRequest.builder().query("Test content").topK(5).build());

assertThat(results).hasSize(2);
results.forEach(result -> {
String id = result.getId();
assertThat(id).isNotNull();
assertThat(id).matches("^[0-9a-fA-F]{24}$");
assertThat(result.getText()).contains("Test content");
assertThat(result.getMetadata()).containsKey(DocumentMetadata.DISTANCE.value());
});
});
}

public static String getText(String uri) {
var resource = new DefaultResourceLoader().getResource(uri);
try {
Expand Down