ChatClientAutoConfiguration should back off if there are multiple ChatModels #3429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...org/springframework/ai/model/chat/client/autoconfigure/ChatClientAutoConfigurationTests.java
Outdated
Show resolved
Hide resolved
filiphr
force-pushed
the
multiple-chat-clients
branch
from
3131e19 to
427ed57
Compare
|
Just wanted to check whether the PR is OK or I need to do some additional changes for it |
…tModels Signed-off-by: Filip Hrisafov <[email protected]>
Signed-off-by: Filip Hrisafov <[email protected]>
filiphr
force-pushed
the
multiple-chat-clients
branch
from
427ed57 to
218ab48
Compare
|
Thanks @ilayaperumalg, I didn't see that PR. They are indeed trying to fix the same issue. Looking forward to either one getting resolved |
|
getting back to this @filiphr |
|
Thanks @markpollack, please let me know if there is anything that you want me to adjust |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If for whatever reason I have multiple
ChatModelbeans available, theChatClientAutoConfigurationis going to fail because noChatClient.Buildercan be created.This PR adds the
@ConditionalOnSingleCandidatefor thechatClientBuilderbean, which allows for smooth startup without the need to manually exclude theChatClientAutoConfiguration