Skip to content

Conversation

jasonparallel
Copy link
Contributor

Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:

  • Sign the contributor license agreement
  • Rebase your changes on the latest main branch and squash your commits
  • Add/Update unit tests as needed
  • Run a build and make sure all tests pass prior to submission

@dev-jonghoonpark
Copy link
Contributor

🙌 Please fix the DCO check by signing your commit. git commit --amend --signoff @jasonparallel

@dev-jonghoonpark
Copy link
Contributor

dev-jonghoonpark commented Jun 7, 2025

Please update license header (20242025)
(see: https://github.com/spring-projects/spring-ai/blob/main/CONTRIBUTING.adoc#update-license-header-to-modified-files-as-necessary)

/*
 * Copyright 2023-2025 the original author or authors.
 *

@dev-jonghoonpark
Copy link
Contributor

dev-jonghoonpark commented Jun 7, 2025

Please update the existing codes(include test code) that uses constructor to use Builder.

@dev-jonghoonpark
Copy link
Contributor

Could you please avoid changing the import order unless necessary? It helps maintain consistency.
Also, kindly avoid modifying the license header unless there's a specific reason.
Thank you!

@dev-jonghoonpark
Copy link
Contributor

dev-jonghoonpark commented Jun 8, 2025

In my personal opinion, it would be better to handle the "Fix Formatter onn typos" task in a separate PR for files that are not related to the Mistral API.

@jasonparallel
Copy link
Contributor Author

@dev-jonghoonpark
I assumed spring-javaformat:apply would put everything as it should be after the eclipse one ran but it looks like that was nto the case. I'll clean it up.

onn fix moved to #3477

@jasonparallel
Copy link
Contributor Author

@dev-jonghoonpark Updated. Will github actions run all the IT with keys on the PR?

@jasonparallel jasonparallel changed the title Add missing builder to follow project patterns Add missing builders to Mistral models to follow project patterns Jun 8, 2025
@dev-jonghoonpark
Copy link
Contributor

@jasonparallel Good job. Let's wait for the maintainer's review.

@jasonparallel
Copy link
Contributor Author

@dev-jonghoonpark Anyone we can ping on this?

return new MistralAiApi(resoledBaseUrl, resolvedApiKey, restClientBuilder, responseErrorHandler);
return MistralAiApi.builder()
.baseUrl(resoledBaseUrl)
.apiKey(apiKey)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be resolvedApiKey. will fix when merging.

@ilayaperumalg ilayaperumalg self-assigned this Sep 26, 2025
@ilayaperumalg
Copy link
Member

@jasonparallel Thanks for the PR. Rebased, fixed the comment, and merged as b8dfc09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants