Cleanup: Cleaned up redundant assignments in TextReader. #3627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er` and unwrapped some unnecessary conditional checks. Signed-off-by: Sun Yuhan <[email protected]>
|
@sunyuhan1998 Thanks for the PR! |
spring-builds
pushed a commit
that referenced
this pull request
Jun 25, 2025
…er` and unwrapped some unnecessary conditional checks. (#3627) Fixes #3627 Signed-off-by: Sun Yuhan <[email protected]> Co-authored-by: Sun Yuhan <[email protected]> (cherry picked from commit c1ee22d)
scionaltera
pushed a commit
to scionaltera/spring-ai
that referenced
this pull request
Sep 3, 2025
…er` and unwrapped some unnecessary conditional checks. (spring-projects#3627) Auto-cherry-pick to 1.0.x Fixes spring-projects#3627 Signed-off-by: Sun Yuhan <[email protected]> Co-authored-by: Sun Yuhan <[email protected]>
chedim
pushed a commit
to couchbaselabs/spring-ai
that referenced
this pull request
Sep 19, 2025
…er` and unwrapped some unnecessary conditional checks. (spring-projects#3627) Auto-cherry-pick to 1.0.x Fixes spring-projects#3627 Signed-off-by: Sun Yuhan <[email protected]> Co-authored-by: Sun Yuhan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
org.springframework.ai.reader.TextReader#getmethod ofTextReader, there was a redundant assignment for theSOURCE_METADATAkey incustomMetadata.In addition, the null checks for the results of
resource.getURI()andresource.getURL()ingetResourceIdentifierwere also unnecessary.