Skip to content

Fix NPE for media-only Document in QdrantVectorStore (GH-3609) #3653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+7 −0
Closed

Fix NPE for media-only Document in QdrantVectorStore (GH-3609) #3653

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...rant-store/src/main/java/org/springframework/ai/vectorstore/qdrant/QdrantVectorStore.java
View file
Open in desktop
Copy link
Contributor

@dev-jonghoonpark dev-jonghoonpark Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

if (!document.isText()) {
    throw new IllegalArgumentException("""
            QdrantVectorStore supports only text-based Document for now –
            received media-only Document; see issue #3609.
            """);
}

var payload = QdrantValueFactory.toValueMap(document.getMetadata());
payload.put(CONTENT_FIELD_NAME, io.qdrant.client.ValueFactory.value(document.getText()));
return payload;

How about this code?

It can prevent unnecessary execution of QdrantValueFactory.toValueMap.
And it's more intuitive.

Copy link
Author

@devMtn30 devMtn30 Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

if (!document.isText()) {
    throw new IllegalArgumentException("""
            QdrantVectorStore supports only text-based Document for now –
            received media-only Document; see issue #3609.
            """);
}

var payload = QdrantValueFactory.toValueMap(document.getMetadata());
payload.put(CONTENT_FIELD_NAME, io.qdrant.client.ValueFactory.value(document.getText()));
return payload;

How about this code?

It can prevent unnecessary execution of QdrantValueFactory.toValueMap. And it's more intuitive.

Thanks for the suggestion-updated!

Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,13 @@ private Document toDocument(ScoredPoint point) {
*/
private Map<String, Value> toPayload(Document document) {
try {
if(!document.isText()) {
throw new IllegalArgumentException("""
QdrantVectorStore supports only text-based Document for now –
received media-only Document; see issue #3609.
""");
}

var payload = QdrantValueFactory.toValueMap(document.getMetadata());
payload.put(CONTENT_FIELD_NAME, io.qdrant.client.ValueFactory.value(document.getText()));
return payload;
Expand Down