fix: remove unused options from ZhiPu model #3669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YunKui Lu <[email protected]>
YunKuiLu
force-pushed
the
fix-zhipu-unused
branch
from
940d2d7 to
b4e3894
Compare
|
@mxsl-gr Could you help with the review please? Thanks! |
mxsl-gr
approved these changes
Jun 26, 2025
hi, @ilayaperumalg I’ve reviewed it, everything looks good. @YunKuiLu thanks for the PR |
sunyuhan1998
approved these changes
Jun 26, 2025
|
@YunKuiLu Thanks for the PR! @mxsl-gr @sunyuhan1998 thanks for the review! |
spring-builds
pushed a commit
that referenced
this pull request
Jun 26, 2025
Fixes #3669 Signed-off-by: YunKui Lu <[email protected]> (cherry picked from commit 906299c)
scionaltera
pushed a commit
to scionaltera/spring-ai
that referenced
this pull request
Sep 3, 2025
Auto-cherry-pick to 1.0.x Fixes spring-projects#3669 Signed-off-by: YunKui Lu <[email protected]>
chedim
pushed a commit
to couchbaselabs/spring-ai
that referenced
this pull request
Sep 19, 2025
Auto-cherry-pick to 1.0.x Fixes spring-projects#3669 Signed-off-by: YunKui Lu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn’t find anything about the tools1 parameter in Zhipu’s official docs. Not sure what this field is for — seems unused.
Also noticed that
buildRequestOptionsmethod isn’t used anywhere. ( It's a private method )