refactor: GH-3620 Add BedrockChatOptions to Bedrock
#3770
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sun Yuhan <[email protected]>
|
Hi @ilayaperumalg , can you help review this? Thank you! |
|
@sunyuhan1998 thank you for the PR! We'll get to it soon. |
...drock-converse/src/main/java/org/springframework/ai/bedrock/converse/BedrockChatOptions.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sun Yuhan <[email protected]>
|
Hi @ilayaperumalg , thank you for helping with the review. May I ask if there are any areas in the current PR that still need adjustment? |
|
@sunyuhan1998 Sorry about the delay. Rebased and merged as 99e59a2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a dedicated
BedrockChatOptionsclass for the Bedrock module, replacing the previously used defaultToolCallingChatOptions. This change aims to better accommodate Bedrock's unique features and parameter requirements, thereby enhancing the module's independence and maintainability.Additionally, this PR also fixes the issues mentioned in issue: #3620 .
This PR includes the following main changes:
Added the
BedrockChatOptionsclass: This class is introduced to centrally manage chat configuration options when interacting with Bedrock models.Replaced the
optionsimplementation inBedrockConverseProxyChatProperties: The previously used configuration class has been replaced with the newly introducedBedrockChatOptionsto ensure consistency and maintainability of the configuration.Updated the configuration usage in related model classes: All references to
ToolCallingChatOptionshave been replaced withBedrockChatOptionsto better align with the specific configuration requirements of Bedrock.Added targeted unit tests: Unit tests have been added for
BedrockChatOptionsand its related logic to ensure functional correctness and future maintainability.Fixes: #3620