Fix exmaple code for "Streaming Responses" #3802
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ingbyr <[email protected]>
sunyuhan1998
approved these changes
Jul 13, 2025
| [source,java] | ||
| ---- | ||
| var converter = new BeanOutputConverter<>(new ParameterizedTypeReference<List<ActorsFilms>>() {}); | ||
| var converter = new BeanOutputConverter<>(new ParameterizedTypeReference<List<ActorFilms>>() {}); |
There was a problem hiding this comment.
I think the current document is correct. The name of this class is currently ActorsFilms, not ActorFilms. Could you please double-check?
There was a problem hiding this comment.
I changed the class name to be consistent with the test code, and I think the class type should be the same in the following two lines
| * Non-streaming is only supportive via the Servlet stack. Reactive applications must include the Servlet stack for this reason (e.g. spring-boot-starter-web) and expect some calls to be blocking. | ||
| * Tool calling is imperative, leading to blocking workflows. This also results in partial/interrupted Micrometer observations (e.g. the ChatClient spans and the tool calling spans are not connected, with the first one remaining incomplete for that reason). | ||
| * The built-in advisors perform blocking operations for standards calls, and non-blocking operations for streaming calls. The Reactor Scheduler used for the advisor streaming calls can be configured via the Builder on each Advisor class. | ||
| * The built-in advisors perform blocking operations for standards calls, and non-blocking operations for streaming calls. The Reactor Scheduler used for the advisor streaming calls can be configured via the Builder on each Advisor class. |
There was a problem hiding this comment.
No modifications seem to have been made here?
There was a problem hiding this comment.
Sorry, I may have accidentally changed the line break. I have changed it back
This reverts commit 3995d6b. Signed-off-by: ingbyr <[email protected]>
Signed-off-by: ingbyr <[email protected]>
spring-builds
pushed a commit
that referenced
this pull request
Jul 16, 2025
* Fix example code for "Streaming Responses" Fixes #3802 Signed-off-by: ingbyr <[email protected]> (cherry picked from commit 42210d3)
|
@ingbyr Thanks for the PR fixing the documentation. |
scionaltera
pushed a commit
to scionaltera/spring-ai
that referenced
this pull request
Sep 3, 2025
* Fix example code for "Streaming Responses" Auto-cherry-pick to 1.0.x Fixes spring-projects#3802 Signed-off-by: ingbyr <[email protected]>
chedim
pushed a commit
to couchbaselabs/spring-ai
that referenced
this pull request
Sep 19, 2025
* Fix example code for "Streaming Responses" Auto-cherry-pick to 1.0.x Fixes spring-projects#3802 Signed-off-by: ingbyr <[email protected]>
Willam2004
pushed a commit
to Willam2004/spring-ai
that referenced
this pull request
Oct 11, 2025
* Fix example code for "Streaming Responses" Auto-cherry-pick to 1.0.x Fixes spring-projects#3802 Signed-off-by: ingbyr <[email protected]> Signed-off-by: 家娃 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for taking time to contribute this pull request!
You might have already read the contributor guide, but as a reminder, please make sure to:
git commit -s) per the DCOmainbranch and squash your commitsFor more details, please check the contributor guide.
Thank you upfront!