Skip to content

Use maven wrapper and batch-mode in GitHub Actions#3841

Merged
sobychacko merged 1 commit intospring-projects:mainfrom
filiphr:maven-batch-mode-github-actions
Aug 6, 2025
Merged

Use maven wrapper and batch-mode in GitHub Actions#3841
sobychacko merged 1 commit intospring-projects:mainfrom
filiphr:maven-batch-mode-github-actions

Conversation

@filiphr
Copy link
Contributor

@filiphr filiphr commented Jul 17, 2025

I noticed that some of the GitHub actions are using mvn and not ./mvnw the Maven Wrapper part of the project. Additionally I noticed that some commands are not using --batch-mode. This leads to builds which have:

Downloaded from central-portal-snapshots: https://central.sonatype.com/repository/maven-snapshots/io/modelcontextprotocol/sdk/mcp-bom/0.11.0-SNAPSHOT/mcp-bom-0.11.0-20250716.113131-38.pom (2.1 kB at 8.4 kB/s)
Downloading from central: https://repo.maven.apache.org/maven2/org/codehaus/plexus/plexus-utils/1.1/plexus-utils-1.1.jar
Progress (1): 4.1/169 kB
Progress (1): 8.2/169 kB
Progress (1): 12/169 kB 
Progress (1): 16/169 kB
Progress (1): 20/169 kB

The default "CI/CD build" already contains --batch-mode. However, some other ones such as the "Documentation Upload" or more importantly the "PR Check" did not, which make them way to noisy when you want to see what is happening. I would even argue that for "PR Check" the --no-transfer-progress could be used, in which case the

[INFO] Downloading from maven-central: https://repo.maven.apache.org/maven2/org/jetbrains/kotlin/kotlin-bom/1.9.25/kotlin-bom-1.9.25.pom
[INFO] Downloaded from maven-central: https://repo.maven.apache.org/maven2/org/jetbrains/kotlin/kotlin-bom/1.9.25/kotlin-bom-1.9.25.pom (9.1 kB at 326 kB/s)

would not be present. Entirely up to you if you prefer to go with the --no-transfer-progress

Signed-off-by: Filip Hrisafov <filip.hrisafov@gmail.com>
@filiphr filiphr force-pushed the maven-batch-mode-github-actions branch from 1cb550f to 3b92380 Compare July 18, 2025 13:53
@sobychacko sobychacko added this to the 1.1.0.M1 milestone Aug 6, 2025
@sobychacko sobychacko merged commit e0ccc13 into spring-projects:main Aug 6, 2025
2 checks passed
scionaltera pushed a commit to scionaltera/spring-ai that referenced this pull request Sep 3, 2025
)

Signed-off-by: Filip Hrisafov <filip.hrisafov@gmail.com>
Willam2004 pushed a commit to Willam2004/spring-ai that referenced this pull request Oct 11, 2025
)

Signed-off-by: Filip Hrisafov <filip.hrisafov@gmail.com>
Signed-off-by: 家娃 <guanjing.pangj@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants