Make OpenAiApi available as a bean for injection #3888
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract OpenAiApi creation to a separate @bean method - Update OpenAiChatModel to inject the OpenAiApi bean - Add test to verify OpenAiApi bean registration This allows users to inject OpenAiApi directly as suggested in the documentation for configuring multiple OpenAI-compatible ChatClients. Fixes spring-projects#3878 Signed-off-by: Hyunjoon Park <[email protected]>
Contributor
|
Merged via f41c27d and backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
This PR addresses #3878 where OpenAiApi was not available for injection despite documentation suggesting it could be used to configure multiple OpenAI-compatible ChatClients.
Changes
OpenAiChatAutoConfiguration.java:
openAiApifrom private method to public@BeanmethodopenAiChatModelto inject the OpenAiApi beanOpenAiModelConfigurationTests.java:
chatModelActivationtestopenAiApiBeanto specifically test OpenAiApi bean injectionTesting
All existing tests pass, plus new test confirms OpenAiApi can be injected as a bean.
Fixes #3878
Signed-off-by: Hyunjoon Park [email protected]