Skip to content

test: improve coverage PgVectorEmbeddingDimensionsTests #3907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 6, 2025
Merged

test: improve coverage PgVectorEmbeddingDimensionsTests #3907

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f6c2f6
test: improve coverage PgVectorEmbeddingDimensionsTests
alxkm Jul 24, 2025
56f65c3
style: fix formatting
alxkm Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 56 additions & 7 deletions ...st/java/org/springframework/ai/vectorstore/pgvector/PgVectorEmbeddingDimensionsTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,25 +58,74 @@ public void explicitlySetDimensions() {

@Test
public void embeddingModelDimensions() {
given(this.embeddingModel.dimensions()).willReturn(969);
int expectedDimensions = 969;
given(this.embeddingModel.dimensions()).willReturn(expectedDimensions);

PgVectorStore pgVectorStore = PgVectorStore.builder(this.jdbcTemplate, this.embeddingModel).build();
var dim = pgVectorStore.embeddingDimensions();

assertThat(dim).isEqualTo(969);
int actualDimensions = pgVectorStore.embeddingDimensions();

assertThat(actualDimensions).isEqualTo(expectedDimensions);
verify(this.embeddingModel, only()).dimensions();
}

@Test
public void fallBackToDefaultDimensions() {
given(this.embeddingModel.dimensions()).willThrow(new RuntimeException("Embedding model error"));

PgVectorStore pgVectorStore = PgVectorStore.builder(this.jdbcTemplate, this.embeddingModel).build();
int actualDimensions = pgVectorStore.embeddingDimensions();

assertThat(actualDimensions).isEqualTo(PgVectorStore.OPENAI_EMBEDDING_DIMENSION_SIZE);
verify(this.embeddingModel, only()).dimensions();
}

@Test
public void embeddingModelReturnsZeroDimensions() {
given(this.embeddingModel.dimensions()).willReturn(0);

PgVectorStore pgVectorStore = PgVectorStore.builder(this.jdbcTemplate, this.embeddingModel).build();
int actualDimensions = pgVectorStore.embeddingDimensions();

assertThat(actualDimensions).isEqualTo(PgVectorStore.OPENAI_EMBEDDING_DIMENSION_SIZE);
verify(this.embeddingModel, only()).dimensions();
}

given(this.embeddingModel.dimensions()).willThrow(new RuntimeException());
@Test
public void embeddingModelReturnsNegativeDimensions() {
given(this.embeddingModel.dimensions()).willReturn(-5);

PgVectorStore pgVectorStore = PgVectorStore.builder(this.jdbcTemplate, this.embeddingModel).build();
var dim = pgVectorStore.embeddingDimensions();
int actualDimensions = pgVectorStore.embeddingDimensions();

assertThat(actualDimensions).isEqualTo(PgVectorStore.OPENAI_EMBEDDING_DIMENSION_SIZE);
verify(this.embeddingModel, only()).dimensions();
}

@Test
public void explicitZeroDimensionsUsesEmbeddingModel() {
int embeddingModelDimensions = 768;
given(this.embeddingModel.dimensions()).willReturn(embeddingModelDimensions);

PgVectorStore pgVectorStore = PgVectorStore.builder(this.jdbcTemplate, this.embeddingModel)
.dimensions(0)
.build();
int actualDimensions = pgVectorStore.embeddingDimensions();

assertThat(actualDimensions).isEqualTo(embeddingModelDimensions);
verify(this.embeddingModel, only()).dimensions();
}

@Test
public void explicitNegativeDimensionsUsesEmbeddingModel() {
int embeddingModelDimensions = 512;
given(this.embeddingModel.dimensions()).willReturn(embeddingModelDimensions);

PgVectorStore pgVectorStore = PgVectorStore.builder(this.jdbcTemplate, this.embeddingModel)
.dimensions(-1)
.build();
int actualDimensions = pgVectorStore.embeddingDimensions();

assertThat(dim).isEqualTo(PgVectorStore.OPENAI_EMBEDDING_DIMENSION_SIZE);
assertThat(actualDimensions).isEqualTo(embeddingModelDimensions);
verify(this.embeddingModel, only()).dimensions();
}

Expand Down