Skip to content

Refactor SummaryMetadataEnricher for improved readability #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Refactor SummaryMetadataEnricher for improved readability #394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 47 additions & 21 deletions spring-ai-core/src/main/java/org/springframework/ai/transformer/SummaryMetadataEnricher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

package org.springframework.ai.transformer;

import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -94,33 +93,60 @@ public SummaryMetadataEnricher(ChatClient chatClient, List<SummaryType> summaryT

@Override
public List<Document> apply(List<Document> documents) {
List<String> documentSummaries = summaryDocuments(documents);

List<String> documentSummaries = new ArrayList<>();
for (Document document : documents) {
for (int i = 0; i < documentSummaries.size(); i++) {
Map<String, Object> summaryMetadata = extractSummaryMetadata(documentSummaries, i);
documents.get(i).getMetadata().putAll(summaryMetadata);
}

var documentContext = document.getFormattedContent(this.metadataMode);
return documents;
}

Prompt prompt = new PromptTemplate(this.summaryTemplate)
.create(Map.of(CONTEXT_STR_PLACEHOLDER, documentContext));
documentSummaries.add(this.chatClient.call(prompt).getResult().getOutput().getContent());
}
private List<String> summaryDocuments(List<Document> documents) {
return documents.stream()
.map(this::summarySingleDocument)
.toList();
}

for (int i = 0; i < documentSummaries.size(); i++) {
Map<String, Object> summaryMetadata = new HashMap<>();
if (i > 0 && this.summaryTypes.contains(SummaryType.PREVIOUS)) {
summaryMetadata.put(PREV_SECTION_SUMMARY_METADATA_KEY, documentSummaries.get(i - 1));
}
if (i < (documentSummaries.size() - 1) && this.summaryTypes.contains(SummaryType.NEXT)) {
summaryMetadata.put(NEXT_SECTION_SUMMARY_METADATA_KEY, documentSummaries.get(i + 1));
}
if (this.summaryTypes.contains(SummaryType.CURRENT)) {
summaryMetadata.put(SECTION_SUMMARY_METADATA_KEY, documentSummaries.get(i));
}
private Map<String, Object> extractSummaryMetadata(List<String> documentSummaries, int nowIndex) {
final int prevIndex = nowIndex - 1;
final int nextIndex = nowIndex + 1;

documents.get(i).getMetadata().putAll(summaryMetadata);
Map<String, Object> summaryMetadata = new HashMap<>();

if (nowIndex > 0 && this.summaryTypes.contains(SummaryType.PREVIOUS)) {
summaryMetadata.put(PREV_SECTION_SUMMARY_METADATA_KEY, documentSummaries.get(prevIndex));
}
if (nowIndex < (documentSummaries.size() - 1) && this.summaryTypes.contains(SummaryType.NEXT)) {
summaryMetadata.put(NEXT_SECTION_SUMMARY_METADATA_KEY, documentSummaries.get(nextIndex));
}
if (this.summaryTypes.contains(SummaryType.CURRENT)) {
summaryMetadata.put(SECTION_SUMMARY_METADATA_KEY, documentSummaries.get(nowIndex));
}

return documents;
return summaryMetadata;
}

private String summarySingleDocument(Document document) {
var documentContext = document.getFormattedContent(this.metadataMode);

Prompt prompt = createPromptByContext(documentContext);

return getContentFromPrompt(prompt);
}

private Prompt createPromptByContext(String documentContext) {
return new PromptTemplate(this.summaryTemplate)
.create(Map.of(CONTEXT_STR_PLACEHOLDER, documentContext));
}

private String getContentFromPrompt(Prompt prompt) {
return this.chatClient
.call(prompt)
.getResult()
.getOutput()
.getContent();
}

}