test: Add comprehensive test coverage for MariaDBFilterExpressionConverter#3943
Merged
sobychacko merged 1 commit intospring-projects:mainfrom Aug 6, 2025
Conversation
…erter Signed-off-by: Alex Klimenko <alexanderklmn@gmail.com>
alxkm
changed the title
MariaDBFilterExpressionConverter
scionaltera
pushed a commit
to scionaltera/spring-ai
that referenced
this pull request
Sep 3, 2025
…erter (spring-projects#3943) Added new test cases covering edge cases and complex scenarios Refactored existing tests to use neutral domain terminology Improved test coverage for: - Empty/single-item lists - Null values and empty strings - Nested JSON paths and array indexing - Mixed data types (boolean, numeric, string) - Complex nested groupings - Special characters and numeric strings Details - Enhanced robustness of filter expression conversion - Better validation of edge cases - Domain-neutral test data for broader applicability Signed-off-by: Alex Klimenko <alexanderklmn@gmail.com>
Willam2004
pushed a commit
to Willam2004/spring-ai
that referenced
this pull request
Oct 11, 2025
…erter (spring-projects#3943) Added new test cases covering edge cases and complex scenarios Refactored existing tests to use neutral domain terminology Improved test coverage for: - Empty/single-item lists - Null values and empty strings - Nested JSON paths and array indexing - Mixed data types (boolean, numeric, string) - Complex nested groupings - Special characters and numeric strings Details - Enhanced robustness of filter expression conversion - Better validation of edge cases - Domain-neutral test data for broader applicability Signed-off-by: Alex Klimenko <alexanderklmn@gmail.com> Signed-off-by: 家娃 <guanjing.pangj@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added new test cases covering edge cases and complex scenarios
Refactored existing tests to use neutral domain terminology
Improved test coverage for:
Details