Issue 3890 Tool call results returned via ChatResponse lack identification metadata#3944
Open
wilocu wants to merge 1 commit intospring-projects:mainfrom
Open
Issue 3890 Tool call results returned via ChatResponse lack identification metadata#3944wilocu wants to merge 1 commit intospring-projects:mainfrom
wilocu wants to merge 1 commit intospring-projects:mainfrom
Conversation
Signed-off-by: Mattia Pasetto <matpat17@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3890
Summary
This PR adds the ability to distinguish between model-generated and tool-generated responses in OllamaChatModel by adding source metadata to
ChatResponse objects. Frontend developers can now easily identify the origin of each response through standardized metadata fields.
Changes Made
Core Implementation:
generation metadata
responses
Testing:
Usage
Developers can now identify response sources:
ChatResponse response = chatModel.call(new Prompt("Hello"));
String source = (String) response.getResult().getMetadata().get("source");
// Returns: "model" for model-generated responses
// Returns: "tool" for tool-generated responses
Testing
This implementation provides a clean, maintainable solution that enables frontend developers to easily differentiate between response sources
while maintaining full backward compatibility.
Signed-off-by: Mattia Pasetto matpat17@gmail.com
I am still pretty new to contributions, please double check and let me know of any errors.