Skip to content

Don't log AWS SDK stack trace, updates documentation #3952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

Don't log AWS SDK stack trace, updates documentation #3952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...converse/src/main/java/org/springframework/ai/bedrock/converse/BedrockProxyChatModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,7 +803,7 @@ private Builder() {
this.region = DefaultAwsRegionProviderChain.builder().build().getRegion();
}
catch (SdkClientException e) {
logger.warn("Failed to load region from DefaultAwsRegionProviderChain, using US_EAST_1", e);
logger.warn("Failed to load region from DefaultAwsRegionProviderChain, using {}}", this.region);
}
}

Expand Down
4 changes: 3 additions & 1 deletion spring-ai-docs/src/main/antora/modules/ROOT/pages/api/chat/bedrock-converse.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ The prefix `spring.ai.bedrock.aws` is the property prefix to configure the conne
|====
| Property | Description | Default

| spring.ai.bedrock.aws.region | AWS region to use. | us-east-1
| spring.ai.bedrock.aws.region | AWS region to use. | AWS SDK value or us-east-1
| spring.ai.bedrock.aws.timeout | AWS timeout to use. | 5m
| spring.ai.bedrock.aws.access-key | AWS access key. | -
| spring.ai.bedrock.aws.secret-key | AWS secret key. | -
Expand All @@ -89,6 +89,8 @@ To enable, spring.ai.model.chat=bedrock-converse (It is enabled by default)
To disable, spring.ai.model.chat=none (or any value which doesn't match bedrock-converse)

This change is done to allow configuration of multiple models.

The AWS SDK checks several places for the region, if none of these are set then "us-east-1" is used.
====

The prefix `spring.ai.bedrock.converse.chat` is the property prefix that configures the chat model implementation for the Converse API.
Expand Down