Skip to content

Conversation

@alxkm
Copy link
Contributor

@alxkm alxkm commented Aug 6, 2025

Added extensive test coverage for configuration options classes:
OCICohereChatOptions:

  • Builder pattern validation (minimal fields, null handling)
  • Deep copy verification and immutability testing
  • Boundary value testing (min/max values for temperature, topP, etc.)
  • Collection handling (empty lists, null setters)
  • State transition testing

AzureEmbeddingsOptions:

  • Multiple input handling and order preservation
  • Options override behavior
  • Different metadata modes
  • Concurrent request isolation
  • Empty input edge cases

WeaviateVectorStoreOptions:

  • Input validation with proper error messages
  • Special character and whitespace handling
  • State preservation during partial failures
  • Case sensitivity verification
  • Default value behavior

These tests improve robustness by covering edge cases, boundary conditions, and ensuring proper immutability/deep copying behavior that prevents reference sharing bugs in production.

@alxkm alxkm changed the title test: Add comprehensive test coverage for chat and embedding options classes test: Add comprehensive test coverage for OCICohereChatOptions, AzureEmbeddingsOptions, WeaviateVectorStoreOptions classes Aug 6, 2025
@sobychacko sobychacko added this to the 1.1.0.M1 milestone Aug 6, 2025
@sobychacko sobychacko merged commit 5be2509 into spring-projects:main Aug 6, 2025
2 checks passed
juntae6942 pushed a commit to juntae6942/spring-ai that referenced this pull request Aug 7, 2025
…classes (spring-projects#4041)

- OCICohereChatOptions
- AzureEmbeddingsOptions
- WeaviateVectorStoreOptions

Signed-off-by: Alex Klimenko <[email protected]>
scionaltera pushed a commit to scionaltera/spring-ai that referenced this pull request Sep 3, 2025
…classes (spring-projects#4041)

- OCICohereChatOptions
- AzureEmbeddingsOptions
- WeaviateVectorStoreOptions

Signed-off-by: Alex Klimenko <[email protected]>
chedim pushed a commit to couchbaselabs/spring-ai that referenced this pull request Sep 19, 2025
…classes (spring-projects#4041)

- OCICohereChatOptions
- AzureEmbeddingsOptions
- WeaviateVectorStoreOptions

Signed-off-by: Alex Klimenko <[email protected]>
Willam2004 pushed a commit to Willam2004/spring-ai that referenced this pull request Oct 11, 2025
…classes (spring-projects#4041)

- OCICohereChatOptions
- AzureEmbeddingsOptions
- WeaviateVectorStoreOptions

Signed-off-by: Alex Klimenko <[email protected]>
Signed-off-by: 家娃 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants