Skip to content

Conversation

@alxkm
Copy link
Contributor

@alxkm alxkm commented Aug 6, 2025

Adds thorough test coverage for PostgresMlEmbeddingOptions and AzureOpenAiChatOptions which include:

PostgresMlEmbeddingOptions

  • Empty and complex kwargs handling
  • All vector types and metadata modes validation
  • Option merging with null inputs and preservation of original options
  • Builder pattern chaining behavior
  • Edge cases for complex nested kwargs structures

AzureOpenAiChatOptions

  • Minimal configuration options validation
  • Empty collections handling (stop lists, logit bias)
  • Disabled logprobs configuration
  • Single stop sequence processing
  • Builder pattern validation
  • Parameterized testing for response format types

These tests ensure robust validation of embedding configuration options and proper handling of various input scenarios.
Improves reliability by testing boundary conditions and various configuration scenarios that weren't previously covered.

…PostgresMlEmbeddingOptions

Signed-off-by: Alex Klimenko <[email protected]>
@alxkm alxkm changed the title test: Add comprehensive test coverage for AzureOpenAiChatOptions and PostgresMlEmbeddingOptions test: Add comprehensive test coverage for AzureOpenAiChatOptions and PostgresMlEmbeddingOptions Aug 6, 2025
@sobychacko sobychacko added this to the 1.1.0.M1 milestone Aug 6, 2025
@sobychacko sobychacko merged commit 4e486c1 into spring-projects:main Aug 6, 2025
2 checks passed
juntae6942 pushed a commit to juntae6942/spring-ai that referenced this pull request Aug 7, 2025
scionaltera pushed a commit to scionaltera/spring-ai that referenced this pull request Sep 3, 2025
chedim pushed a commit to couchbaselabs/spring-ai that referenced this pull request Sep 19, 2025
Willam2004 pushed a commit to Willam2004/spring-ai that referenced this pull request Oct 11, 2025
…PostgresMlEmbeddingOptions (spring-projects#4042)

Signed-off-by: Alex Klimenko <[email protected]>
Signed-off-by: 家娃 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants