Polish: Use Optional to check null, and avoid NPE.
#4063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mengqi Xu <[email protected]>
remeio
force-pushed
the
polish_null_check
branch
from
6602220 to
80f2fa9
Compare
spring-builds
pushed a commit
that referenced
this pull request
Aug 8, 2025
Fixes #4063 Signed-off-by: Mengqi Xu <[email protected]> (cherry picked from commit 27b09fe)
tzolov
pushed a commit
to tzolov/spring-ai
that referenced
this pull request
Aug 17, 2025
Fixes spring-projects#4063 Auto-cherry-pick to 1.0.x Signed-off-by: Mengqi Xu <[email protected]>
scionaltera
pushed a commit
to scionaltera/spring-ai
that referenced
this pull request
Sep 3, 2025
Fixes spring-projects#4063 Auto-cherry-pick to 1.0.x Signed-off-by: Mengqi Xu <[email protected]>
chedim
pushed a commit
to couchbaselabs/spring-ai
that referenced
this pull request
Sep 19, 2025
Fixes spring-projects#4063 Auto-cherry-pick to 1.0.x Signed-off-by: Mengqi Xu <[email protected]>
Willam2004
pushed a commit
to Willam2004/spring-ai
that referenced
this pull request
Oct 11, 2025
Fixes spring-projects#4063 Auto-cherry-pick to 1.0.x Signed-off-by: Mengqi Xu <[email protected]> Signed-off-by: 家娃 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use
Optionalto check null, otherwise we will have too many null check. And avoid NPE.In the code design, we have too many nested levels,
Optionalis a good choice.