Skip to content

Refactor and centralize Retry logic #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Refactor and centralize Retry logic #412

wants to merge 1 commit into from

Conversation

tzolov
Copy link
Contributor

@tzolov tzolov commented Mar 7, 2024

  • Establish a new "spring-ai-retry" project, implementing a default HTTP error handler, RetryTemplate, and handling both Transient and Non-Transient Exceptions.
  • Streamline existing clients (e.g., OpenAI and MistralAI) to utilize "spring-ai-retry."
  • Integrate retry auto-configuration with customizable properties, extending it to OpenAI and MistralAI Auto-Configs.
  • Allow configuration of RetryTemplate and ResponseErrorHandler for various clients, including OpenAIChatClient, OpenAiEmbeddingClient, OpenAiAudioTranscriptionCline, OpenAiImageClient, MistralAiChatClient, and MistralAiEmbeddingClient.
  • Add tests for default RestTemplate and ResponseErrorHandler configurations in OpenAI and MistralAI.
  • Introduce new retry auto-config properties: "noRetryOnHttpClientErrors" and "noRetryOnHttpCodes."
  • Implement tests for retry auto-config properties.
  • Generate missing license headers.

@tzolov
Refactor and centralize Retry logic:
c545dd2 
 - Establish a new "spring-ai-retry" project, implementing a default HTTP error handler,
   RetryTemplate, and handling both Transient and Non-Transient Exceptions.
 - Streamline existing clients (e.g., OpenAI and MistralAI) to utilize "spring-ai-retry."
 - Integrate retry auto-configuration with customizable properties, extending it to OpenAI and MistralAI Auto-Configs.
 - Allow configuration of RetryTemplate and ResponseErrorHandler for various clients, including OpenAIChatClient,
   OpenAiEmbeddingClient, OpenAiAudioTranscriptionCline, OpenAiImageClient, MistralAiChatClient, and MistralAiEmbeddingClient.
 - Add tests for default RestTemplate and ResponseErrorHandler configurations in OpenAI and MistralAI.
 - Introduce new retry auto-config properties: "noRetryOnHttpClientErrors" and "noRetryOnHttpCodes."
 - Implement tests for retry auto-config properties.
 - Generate missing license headers.
@tzolov tzolov added this to the 0.8.1 milestone Mar 7, 2024
@markpollack
Copy link
Member

merged after review as 1e3eaec

@markpollack markpollack closed this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@tzolov @markpollack