Skip to content

Polish bean name #4146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
Merged

Polish bean name #4146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../ai/mcp/client/webflux/autoconfigure/StreamableHttpWebFluxTransportAutoConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public class StreamableHttpWebFluxTransportAutoConfiguration {
* @return list of named MCP transports
*/
@Bean
public List<NamedClientMcpTransport> streamableHttpwebFluxClientTransports(
public List<NamedClientMcpTransport> streamableHttpWebFluxClientTransports(
McpStreamableHttpClientProperties streamableProperties,
ObjectProvider<WebClient.Builder> webClientBuilderProvider,
ObjectProvider<ObjectMapper> objectMapperProvider) {
Expand Down
22 changes: 11 additions & 11 deletions ...cp/client/webflux/autoconfigure/StreamableHttpWebFluxTransportAutoConfigurationTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,27 +48,27 @@ public class StreamableHttpWebFluxTransportAutoConfigurationTests {
@Test
void webFluxClientTransportsPresentIfWebClientStreamableHttpTransportPresent() {
this.applicationContext
.run(context -> assertThat(context.containsBean("streamableHttpwebFluxClientTransports")).isTrue());
.run(context -> assertThat(context.containsBean("streamableHttpWebFluxClientTransports")).isTrue());
}

@Test
void webFluxClientTransportsNotPresentIfMissingWebClientStreamableHttpTransportNotPresent() {
this.applicationContext
.withClassLoader(new FilteredClassLoader(
"io.modelcontextprotocol.client.transport.WebClientStreamableHttpTransport"))
.run(context -> assertThat(context.containsBean("streamableHttpwebFluxClientTransports")).isFalse());
.run(context -> assertThat(context.containsBean("streamableHttpWebFluxClientTransports")).isFalse());
}

@Test
void webFluxClientTransportsNotPresentIfMcpClientDisabled() {
this.applicationContext.withPropertyValues("spring.ai.mcp.client.enabled", "false")
.run(context -> assertThat(context.containsBean("streamableHttpwebFluxClientTransports")).isFalse());
.run(context -> assertThat(context.containsBean("streamableHttpWebFluxClientTransports")).isFalse());
}

@Test
void noTransportsCreatedWithEmptyConnections() {
this.applicationContext.run(context -> {
List<NamedClientMcpTransport> transports = context.getBean("streamableHttpwebFluxClientTransports",
List<NamedClientMcpTransport> transports = context.getBean("streamableHttpWebFluxClientTransports",
List.class);
assertThat(transports).isEmpty();
});
Expand All @@ -79,7 +79,7 @@ void singleConnectionCreatesOneTransport() {
this.applicationContext
.withPropertyValues("spring.ai.mcp.client.streamable-http.connections.server1.url=http://localhost:8080")
.run(context -> {
List<NamedClientMcpTransport> transports = context.getBean("streamableHttpwebFluxClientTransports",
List<NamedClientMcpTransport> transports = context.getBean("streamableHttpWebFluxClientTransports",
List.class);
assertThat(transports).hasSize(1);
assertThat(transports.get(0).name()).isEqualTo("server1");
Expand All @@ -93,7 +93,7 @@ void multipleConnectionsCreateMultipleTransports() {
.withPropertyValues("spring.ai.mcp.client.streamable-http.connections.server1.url=http://localhost:8080",
"spring.ai.mcp.client.streamable-http.connections.server2.url=http://otherserver:8081")
.run(context -> {
List<NamedClientMcpTransport> transports = context.getBean("streamableHttpwebFluxClientTransports",
List<NamedClientMcpTransport> transports = context.getBean("streamableHttpWebFluxClientTransports",
List.class);
assertThat(transports).hasSize(2);
assertThat(transports).extracting("name").containsExactlyInAnyOrder("server1", "server2");
Expand All @@ -113,7 +113,7 @@ void customStreamableHttpEndpointIsRespected() {
.withPropertyValues("spring.ai.mcp.client.streamable-http.connections.server1.url=http://localhost:8080",
"spring.ai.mcp.client.streamable-http.connections.server1.endpoint=/custom-mcp")
.run(context -> {
List<NamedClientMcpTransport> transports = context.getBean("streamableHttpwebFluxClientTransports",
List<NamedClientMcpTransport> transports = context.getBean("streamableHttpWebFluxClientTransports",
List.class);
assertThat(transports).hasSize(1);
assertThat(transports.get(0).name()).isEqualTo("server1");
Expand All @@ -130,7 +130,7 @@ void customWebClientBuilderIsUsed() {
.withPropertyValues("spring.ai.mcp.client.streamable-http.connections.server1.url=http://localhost:8080")
.run(context -> {
assertThat(context.getBean(WebClient.Builder.class)).isNotNull();
List<NamedClientMcpTransport> transports = context.getBean("streamableHttpwebFluxClientTransports",
List<NamedClientMcpTransport> transports = context.getBean("streamableHttpWebFluxClientTransports",
List.class);
assertThat(transports).hasSize(1);
});
Expand All @@ -142,7 +142,7 @@ void customObjectMapperIsUsed() {
.withPropertyValues("spring.ai.mcp.client.streamable-http.connections.server1.url=http://localhost:8080")
.run(context -> {
assertThat(context.getBean(ObjectMapper.class)).isNotNull();
List<NamedClientMcpTransport> transports = context.getBean("streamableHttpwebFluxClientTransports",
List<NamedClientMcpTransport> transports = context.getBean("streamableHttpWebFluxClientTransports",
List.class);
assertThat(transports).hasSize(1);
});
Expand All @@ -153,7 +153,7 @@ void defaultStreamableHttpEndpointIsUsedWhenNotSpecified() {
this.applicationContext
.withPropertyValues("spring.ai.mcp.client.streamable-http.connections.server1.url=http://localhost:8080")
.run(context -> {
List<NamedClientMcpTransport> transports = context.getBean("streamableHttpwebFluxClientTransports",
List<NamedClientMcpTransport> transports = context.getBean("streamableHttpWebFluxClientTransports",
List.class);
assertThat(transports).hasSize(1);
assertThat(transports.get(0).name()).isEqualTo("server1");
Expand All @@ -170,7 +170,7 @@ void mixedConnectionsWithAndWithoutCustomStreamableHttpEndpoint() {
"spring.ai.mcp.client.streamable-http.connections.server1.endpoint=/custom-mcp",
"spring.ai.mcp.client.streamable-http.connections.server2.url=http://otherserver:8081")
.run(context -> {
List<NamedClientMcpTransport> transports = context.getBean("streamableHttpwebFluxClientTransports",
List<NamedClientMcpTransport> transports = context.getBean("streamableHttpWebFluxClientTransports",
List.class);
assertThat(transports).hasSize(2);
assertThat(transports).extracting("name").containsExactlyInAnyOrder("server1", "server2");
Expand Down