Skip to content

test: Enhance test coverage for SyncMcpToolCallback edge cases #4154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2025
Merged

test: Enhance test coverage for SyncMcpToolCallback edge cases #4154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions mcp/common/src/test/java/org/springframework/ai/mcp/SyncMcpToolCallbackTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,4 +130,52 @@ void callShouldWrapExceptions() {
.hasMessage("Testing tool error");
}

@Test
void callShouldHandleEmptyResponse() {
when(this.tool.name()).thenReturn("testTool");
CallToolResult callResult = mock(CallToolResult.class);
when(callResult.isError()).thenReturn(false);
when(callResult.content()).thenReturn(List.of());
when(this.mcpClient.callTool(any(CallToolRequest.class))).thenReturn(callResult);

SyncMcpToolCallback callback = new SyncMcpToolCallback(this.mcpClient, this.tool);

String response = callback.call("{\"param\":\"value\"}");

assertThat(response).isEqualTo("[]");
}

@Test
void callShouldHandleMultipleContentItems() {
when(this.tool.name()).thenReturn("testTool");
CallToolResult callResult = mock(CallToolResult.class);
when(callResult.isError()).thenReturn(false);
when(callResult.content()).thenReturn(
List.of(new McpSchema.TextContent("First content"), new McpSchema.TextContent("Second content")));
when(this.mcpClient.callTool(any(CallToolRequest.class))).thenReturn(callResult);

SyncMcpToolCallback callback = new SyncMcpToolCallback(this.mcpClient, this.tool);

String response = callback.call("{\"param\":\"value\"}");

assertThat(response).isNotNull();
assertThat(response).isEqualTo("[{\"text\":\"First content\"},{\"text\":\"Second content\"}]");
}

@Test
void callShouldHandleNonTextContent() {
when(this.tool.name()).thenReturn("testTool");
CallToolResult callResult = mock(CallToolResult.class);
when(callResult.isError()).thenReturn(false);
when(callResult.content()).thenReturn(List.of(new McpSchema.ImageContent(null, "base64data", "image/png")));
when(this.mcpClient.callTool(any(CallToolRequest.class))).thenReturn(callResult);

SyncMcpToolCallback callback = new SyncMcpToolCallback(this.mcpClient, this.tool);

String response = callback.call("{\"param\":\"value\"}");

assertThat(response).isNotNull();
assertThat(response).isEqualTo("[{\"data\":\"base64data\",\"mimeType\":\"image/png\"}]");
}

}