Skip to content

test: Enhance test coverage for EmbeddingModelObservationContext #4157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2025
Merged

test: Enhance test coverage for EmbeddingModelObservationContext #4157

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3165ea2
test: Enhance test coverage for EmbeddingModelObservationContext
alxkm Aug 14, 2025
5d09119
test: Enhance test coverage for EmbeddingModelObservationContext
alxkm Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 77 additions & 1 deletion ...a/org/springframework/ai/embedding/observation/EmbeddingModelObservationContextTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import org.springframework.ai.embedding.EmbeddingRequest;

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;

/**
* Unit tests for {@link EmbeddingModelObservationContext}.
Expand All @@ -43,8 +44,83 @@ void whenMandatoryRequestOptionsThenReturn() {
assertThat(observationContext).isNotNull();
}

@Test
void whenBuilderWithNullRequestThenThrowsException() {
assertThatThrownBy(() -> EmbeddingModelObservationContext.builder()
.embeddingRequest(null)
.provider("test-provider")
.build()).isInstanceOf(IllegalArgumentException.class).hasMessage("request cannot be null");
}

@Test
void whenBuilderWithNullProviderThenThrowsException() {
var embeddingRequest = generateEmbeddingRequest(EmbeddingOptionsBuilder.builder().model("test-model").build());

assertThatThrownBy(() -> EmbeddingModelObservationContext.builder()
.embeddingRequest(embeddingRequest)
.provider(null)
.build()).isInstanceOf(IllegalArgumentException.class).hasMessage("provider cannot be null or empty");
}

@Test
void whenBuilderWithEmptyProviderThenThrowsException() {
var embeddingRequest = generateEmbeddingRequest(EmbeddingOptionsBuilder.builder().model("test-model").build());

assertThatThrownBy(() -> EmbeddingModelObservationContext.builder()
.embeddingRequest(embeddingRequest)
.provider("")
.build()).isInstanceOf(IllegalArgumentException.class).hasMessage("provider cannot be null or empty");
}

@Test
void whenValidRequestAndProviderThenBuildsSuccessfully() {
var embeddingRequest = generateEmbeddingRequest(EmbeddingOptionsBuilder.builder().model("test-model").build());

var observationContext = EmbeddingModelObservationContext.builder()
.embeddingRequest(embeddingRequest)
.provider("valid-provider")
.build();

assertThat(observationContext).isNotNull();
}

@Test
void whenBuilderWithBlankProviderThenThrowsException() {
var embeddingRequest = generateEmbeddingRequest(EmbeddingOptionsBuilder.builder().model("test-model").build());

assertThatThrownBy(() -> EmbeddingModelObservationContext.builder()
.embeddingRequest(embeddingRequest)
.provider(" ")
.build()).isInstanceOf(IllegalArgumentException.class).hasMessage("provider cannot be null or empty");
}

@Test
void whenEmbeddingRequestWithNullOptionsThenBuildsSuccessfully() {
var embeddingRequest = generateEmbeddingRequest(null);

var observationContext = EmbeddingModelObservationContext.builder()
.embeddingRequest(embeddingRequest)
.provider("test-provider")
.build();

assertThat(observationContext).isNotNull();
}

@Test
void whenEmbeddingRequestWithEmptyInputListThenBuildsSuccessfully() {
var embeddingRequest = new EmbeddingRequest(List.of(),
EmbeddingOptionsBuilder.builder().model("test-model").build());

var observationContext = EmbeddingModelObservationContext.builder()
.embeddingRequest(embeddingRequest)
.provider("test-provider")
.build();

assertThat(observationContext).isNotNull();
}

private EmbeddingRequest generateEmbeddingRequest(EmbeddingOptions embeddingOptions) {
return new EmbeddingRequest(List.of(), embeddingOptions);
return new EmbeddingRequest(List.of("test input"), embeddingOptions);
}

}