GH-3300 | Add max_completion_tokens to Azure OpenAI #4177
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfiguration options Signed-off-by: Oskar Drozda <[email protected]>
|
Thanks! I've added tests and noted in the docs the issues with this new options and conflicts with the previous models. merged in 441d005 |
|
The openai code base has been updated similarly. See 13c39f1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've created a new PR that resolved @markpollack issues from previous PR from @iAMSagar44:
#3305
GH issue:
#3300
I inspired myself on similar issue in non-azure openai client:
#1411
#1412
If any changes to this PR are necessary, I'm willing to work on that, as this issue blocks deployment of GPT-5 in our organisation.