Skip to content

Polish MCP related configuration properties bean #4208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Polish MCP related configuration properties bean #4208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .../ai/mcp/server/common/autoconfigure/properties/McpServerChangeNotificationProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

/**
* @author Christian Tzolov
* @see org.springframework.ai.mcp.server.common.autoconfigure.McpServerAutoConfiguration
*/
@ConfigurationProperties(McpServerChangeNotificationProperties.CONFIG_PREFIX)
public class McpServerChangeNotificationProperties {
Expand Down
2 changes: 1 addition & 1 deletion ...rg/springframework/ai/mcp/server/common/autoconfigure/properties/McpServerProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
*
* @author Christian Tzolov
* @since 1.0.0
* @see McpServerAutoConfiguration
* @see org.springframework.ai.mcp.server.common.autoconfigure.McpServerAutoConfiguration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When merging, I will update the latest autoconfiguration changes which use McpServerProperties:

 * @see org.springframework.ai.mcp.server.common.autoconfigure.McpServerAutoConfiguration
 * @see org.springframework.ai.mcp.server.common.autoconfigure.McpServerStatelessAutoConfiguration
 * @see org.springframework.ai.mcp.server.common.autoconfigure.StatelessToolCallbackConverterAutoConfiguration
 * @see org.springframework.ai.mcp.server.common.autoconfigure.ToolCallbackConverterAutoConfiguration

*/
@ConfigurationProperties(McpServerProperties.CONFIG_PREFIX)
public class McpServerProperties {
Expand Down
2 changes: 2 additions & 0 deletions ...springframework/ai/mcp/server/common/autoconfigure/properties/McpServerSseProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@

/**
* @author Christian Tzolov
* @see org.springframework.ai.mcp.server.autoconfigure.McpServerSseWebFluxAutoConfiguration
* @see org.springframework.ai.mcp.server.autoconfigure.McpServerSseWebMvcAutoConfiguration
*/
@ConfigurationProperties(McpServerSseProperties.CONFIG_PREFIX)
public class McpServerSseProperties {
Expand Down
4 changes: 4 additions & 0 deletions ...work/ai/mcp/server/common/autoconfigure/properties/McpServerStreamableHttpProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@

/**
* @author Christian Tzolov
* @see org.springframework.ai.mcp.server.stateless.webflux.autoconfigure.McpServerStatelessWebFluxAutoConfiguration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These auto-configurations are now moved into separate auto-configurations spring-ai-autoconfigure-mcp-server-webflux and spring-ai-autoconfigure-mcp-server-webmvc with the common properties and auto-configurations exist in spring-ai-autoconfigure-mcp-server-common. Hence, I will remove these entries from here when merging.

* @see org.springframework.ai.mcp.server.stateless.webmvc.autoconfigure.McpServerStatelessWebMvcAutoConfiguration
* @see org.springframework.ai.mcp.server.streamable.webflux.autoconfigure.McpServerStreamableHttpWebFluxAutoConfiguration
* @see org.springframework.ai.mcp.server.streamable.webmvc.autoconfigure.McpServerStreamableHttpWebMvcAutoConfiguration
*/
@ConfigurationProperties(McpServerStreamableHttpProperties.CONFIG_PREFIX)
public class McpServerStreamableHttpProperties {
Expand Down
3 changes: 1 addition & 2 deletions ...org/springframework/ai/mcp/server/autoconfigure/McpServerSseWebFluxAutoConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@

import org.springframework.ai.mcp.server.common.autoconfigure.McpServerAutoConfiguration;
import org.springframework.ai.mcp.server.common.autoconfigure.McpServerStdioDisabledCondition;
import org.springframework.ai.mcp.server.common.autoconfigure.properties.McpServerProperties;
import org.springframework.ai.mcp.server.common.autoconfigure.properties.McpServerSseProperties;
import org.springframework.beans.factory.ObjectProvider;
import org.springframework.boot.autoconfigure.AutoConfiguration;
Expand Down Expand Up @@ -70,7 +69,7 @@
* @author Christian Tzolov
* @author Yanming Zhou
* @since 1.0.0
* @see McpServerProperties
* @see McpServerSseProperties
* @see WebFluxSseServerTransportProvider
*/
@AutoConfiguration(before = McpServerAutoConfiguration.class)
Expand Down
3 changes: 1 addition & 2 deletions .../org/springframework/ai/mcp/server/autoconfigure/McpServerSseWebMvcAutoConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@

import org.springframework.ai.mcp.server.common.autoconfigure.McpServerAutoConfiguration;
import org.springframework.ai.mcp.server.common.autoconfigure.McpServerStdioDisabledCondition;
import org.springframework.ai.mcp.server.common.autoconfigure.properties.McpServerProperties;
import org.springframework.ai.mcp.server.common.autoconfigure.properties.McpServerSseProperties;
import org.springframework.beans.factory.ObjectProvider;
import org.springframework.boot.autoconfigure.AutoConfiguration;
Expand Down Expand Up @@ -63,7 +62,7 @@
* @author Christian Tzolov
* @author Yanming Zhou
* @since 1.0.0
* @see McpServerProperties
* @see McpServerSseProperties
* @see WebMvcSseServerTransportProvider
*/
@AutoConfiguration(before = McpServerAutoConfiguration.class)
Expand Down