Skip to content

GH-4205 Optimized the getClassOrNull method in ToolCallingAutoConfiguration #4257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

GH-4205 Optimized the getClassOrNull method in ToolCallingAutoConfiguration #4257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions ...in/java/org/springframework/ai/model/tool/autoconfigure/ToolCallingAutoConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,19 @@ ToolCallingContentObservationFilter toolCallingContentObservationFilter() {

private static Class<? extends RuntimeException> getClassOrNull(String className) {
try {
return (Class<? extends RuntimeException>) ClassUtils.forName(className, null);
Class<?> clazz = ClassUtils.forName(className, null);
if (RuntimeException.class.isAssignableFrom(clazz)) {
return (Class<? extends RuntimeException>) clazz;
}
else {
logger.debug("Class {} is not a subclass of RuntimeException", className);
}
}
catch (ClassNotFoundException e) {
logger.debug("Cannot load class", e);
logger.debug("Cannot load class: {}", className);
Copy link
Contributor

@YunKuiLu YunKuiLu Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This log can still confuse users. Maybe it's better to catch this exception at line 88 and explain why this class is needed.

}
catch (Exception e) {
logger.debug("Error loading class: {}", className, e);
}
return null;
}
Expand Down