Skip to content

GH-4289 Optimized JdbcChatMemoryRepositoryDialect#from #4290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

GH-4289 Optimized JdbcChatMemoryRepositoryDialect#from #4290

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d4d5c60
polish: GH-4289 Optimized `JdbcChatMemoryRepositoryDialect#from`
sunyuhan1998 Sep 2, 2025
59daae5
fix: Fix import
sunyuhan1998 Sep 2, 2025
dd7bae7
fix: Fix import
sunyuhan1998 Sep 2, 2025
7518f0f
fix: Fix import
sunyuhan1998 Sep 2, 2025
ae41f04
fix: Fix UT
sunyuhan1998 Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 27 additions & 23 deletions ...a/org/springframework/ai/chat/memory/repository/jdbc/JdbcChatMemoryRepositoryDialect.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,22 @@

package org.springframework.ai.chat.memory.repository.jdbc;

import java.sql.Connection;
import java.sql.DatabaseMetaData;

import javax.sql.DataSource;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import org.springframework.jdbc.support.JdbcUtils;

/**
* Abstraction for database-specific SQL for chat memory repository.
*/
public interface JdbcChatMemoryRepositoryDialect {

Logger logger = LoggerFactory.getLogger(JdbcChatMemoryRepositoryDialect.class);

/**
* Returns the SQL to fetch messages for a conversation, ordered by timestamp, with
* limit.
Expand All @@ -51,32 +58,29 @@ public interface JdbcChatMemoryRepositoryDialect {
*/

/**
* Detects the dialect from the DataSource or JDBC URL.
* Detects the dialect from the DataSource.
*/
static JdbcChatMemoryRepositoryDialect from(DataSource dataSource) {
// Simple detection (could be improved)
try (Connection connection = dataSource.getConnection()) {
String url = connection.getMetaData().getURL().toLowerCase();
if (url.contains("postgresql")) {
return new PostgresChatMemoryRepositoryDialect();
}
if (url.contains("mysql")) {
return new MysqlChatMemoryRepositoryDialect();
}
if (url.contains("mariadb")) {
return new MysqlChatMemoryRepositoryDialect();
}
if (url.contains("sqlserver")) {
return new SqlServerChatMemoryRepositoryDialect();
}
if (url.contains("hsqldb")) {
return new HsqldbChatMemoryRepositoryDialect();
}
// Add more as needed
String productName = null;
try {
productName = JdbcUtils.extractDatabaseMetaData(dataSource, DatabaseMetaData::getDatabaseProductName);
}
catch (Exception e) {
logger.warn("Due to failure in establishing JDBC connection or parsing metadata, the JDBC database vendor "
+ "could not be determined", e);
}
catch (Exception ignored) {
if (productName == null || productName.trim().isEmpty()) {
logger.warn("Database product name is null or empty, defaulting to Postgres dialect.");
return new PostgresChatMemoryRepositoryDialect();
}
return new PostgresChatMemoryRepositoryDialect(); // default
return switch (productName) {
case "PostgreSQL" -> new PostgresChatMemoryRepositoryDialect();
case "MySQL", "MariaDB" -> new MysqlChatMemoryRepositoryDialect();
case "Microsoft SQL Server" -> new SqlServerChatMemoryRepositoryDialect();
case "HSQL Database Engine" -> new HsqldbChatMemoryRepositoryDialect();
default -> // Add more as needed
new PostgresChatMemoryRepositoryDialect();
};
}

}