refactor(mcp): Add ToolContext to MCP metadata conversion #4328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce ToolContextToMcpMetaConverter interface for converting Spring AI ToolContext to MCP call metadata - Refactor McpToolCallbackAutoConfiguration to use ObjectProvider for flexible dependency injection - Remove automatic McpToolNamePrefixGenerator bean creation in favor of ObjectProvider-based resolution - Add builder pattern for AsyncMcpToolCallback and SyncMcpToolCallback with comprehensive configuration options - Add builder pattern for AsyncMcpToolCallbackProvider and SyncMcpToolCallbackProvider - Enhance tool callback call methods to support ToolContext parameter with metadata conversion - Update MCP tool callbacks to use new CallToolRequest.builder() API - Improve error handling and logging in tool callback implementations - Add comprehensive coverage for new builder functionality - Update documentation with ToolContextToMcpMetaConverter usage examples - Maintain backward compatibility through deprecation of old constructors Breaking changes: - McpToolCallbackAutoConfiguration no longer automatically creates McpToolNamePrefixGenerator bean - Tool callback constructors are now private, use builder() method instead Resolves: spring-projects#3505 Resolves: spring-projects#2868 Resolves: spring-projects#2784 Resolves: spring-projects#2620 Replaces: spring-projects#3831 Signed-off-by: Christian Tzolov <[email protected]> Co-authored-by: YunKui Lu <[email protected]>
tzolov
force-pushed
the
tool-context-to-mcp-meta-conversion
branch
from
010cae4 to
8576ebf
Compare
Signed-off-by: Christian Tzolov <[email protected]> Co-authored-by: YunKui Lu <[email protected]>
sunyuhan1998
approved these changes
Sep 7, 2025
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes:
Resolves: #3505
Resolves: #2868
Resolves: #2784
Resolves: #2620
Replaces: #3831