-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: Add builder for AssistantMessage #4351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
ThomasVitale
wants to merge
1
commit into
spring-projects:main
from
ThomasVitale:gh-add-builder-for-assistant-message
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
...ng-ai-model/src/test/java/org/springframework/ai/chat/messages/AssistantMessageTests.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| /* | ||
| * Copyright 2023-2025 the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.springframework.ai.chat.messages; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThatThrownBy; | ||
|
|
||
| /** | ||
| * Unit tests for {@link AssistantMessage}. | ||
| * | ||
| * @author Thomas Vitale | ||
| */ | ||
| class AssistantMessageTests { | ||
|
|
||
| @Test | ||
| void whenMediaIsNullThenThrow() { | ||
| assertThatThrownBy(() -> AssistantMessage.builder().media(null).build()) | ||
| .isInstanceOf(IllegalArgumentException.class) | ||
| .hasMessageContaining("Media must not be null"); | ||
| } | ||
|
|
||
| @Test | ||
| void whenMetadataIsNullThenThrow() { | ||
| assertThatThrownBy(() -> AssistantMessage.builder().properties(null).build()) | ||
| .isInstanceOf(IllegalArgumentException.class) | ||
| .hasMessageContaining("Metadata must not be null"); | ||
| } | ||
|
|
||
| @Test | ||
| void whenToolCallsIsNullThenThrow() { | ||
| assertThatThrownBy(() -> AssistantMessage.builder().toolCalls(null).build()) | ||
| .isInstanceOf(IllegalArgumentException.class) | ||
| .hasMessageContaining("Tool calls must not be null"); | ||
| } | ||
|
|
||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ThomasVitale What do you think about deprecating this public usage as well - in favour of the builder? This way, new instance of AssistantMessage can only be created via builder only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be fine by me. I know that for
UserMessageandSystemMessagewe opted for keeping the 1-argument constructor for convenience, and forcing theBuilderfor any other use cases where more than one argument needs to be provided. What do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. That's a good point. I like the convenience aspect as well. We can keep the single argument constructor for AssistantMessage as well.