feat: Align EmbeddingOptions builder to ChatOptions #4352
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ThomasVitale
commented
Sep 9, 2025
ThomasVitale
commented
- Add Builder interface under EmbeddingOptions, and provide default implementation with DefaultEmbeddingOptions and DefaultEmbeddingOptionsBuilder. This is to match the design adopted alredy for ChatOptions in 1.0.0
* Add Builder interface under EmbeddingOptions, and provide default implementation with DefaultEmbeddingOptions and DefaultEmbeddingOptionsBuilder. This is to match the design adopted alredy for ChatOptions in 1.0.0 Signed-off-by: Thomas Vitale <[email protected]>
|
@ThomasVitale Thanks for the PR! Rebased and merged as 14d6f58 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.