Update test and docs to use DockerModelRunnerContainer #4353
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testcontainers offers `DockerModelRunnerContainer`. Replace the `SocatContainer` usage with `DockerModelRunnerContainer`. Signed-off-by: Eddú Meléndez <[email protected]>
eddumelendez
force-pushed
the
dmr-update
branch
from
70d5c56 to
a7720d3
Compare
sunyuhan1998
approved these changes
Sep 10, 2025
| @Testcontainers | ||
| @SpringBootTest(classes = DockerModelRunnerWithOpenAiChatModelIT.Config.class) | ||
| @Disabled("Requires Docker Model Runner enabled. See https://docs.docker.com/desktop/features/model-runner/") | ||
| // @Disabled("Requires Docker Model Runner enabled. See |
There was a problem hiding this comment.
@eddumelendez While merging, I am marking this IT test as "Disabled" until the Spring AI IT infrastructure is enabled with docker model runner.
spring-builds
pushed a commit
that referenced
this pull request
Sep 12, 2025
Testcontainers offers `DockerModelRunnerContainer`. Replace the `SocatContainer` usage with `DockerModelRunnerContainer`. Fixes #4353 Signed-off-by: Eddú Meléndez <[email protected]> (cherry picked from commit c7b7d69)
|
@eddumelendez Thanks for the PR! @sunyuhan1998 Thanks for the review. |
chedim
pushed a commit
to couchbaselabs/spring-ai
that referenced
this pull request
Sep 19, 2025
Testcontainers offers `DockerModelRunnerContainer`. Replace the `SocatContainer` usage with `DockerModelRunnerContainer`. Auto-cherry-pick to 1.0.x Fixes spring-projects#4353 Signed-off-by: Eddú Meléndez <[email protected]>
Willam2004
pushed a commit
to Willam2004/spring-ai
that referenced
this pull request
Oct 11, 2025
Testcontainers offers `DockerModelRunnerContainer`. Replace the `SocatContainer` usage with `DockerModelRunnerContainer`. Auto-cherry-pick to 1.0.x Fixes spring-projects#4353 Signed-off-by: Eddú Meléndez <[email protected]> Signed-off-by: 家娃 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testcontainers offers
DockerModelRunnerContainer. Replace theSocatContainerusage withDockerModelRunnerContainer.Signed-off-by: Eddú Meléndez [email protected]