GH-4472 Fixed an issue in the mergeToolUseEvents method of StreamHelper#4474
Closed
sunyuhan1998 wants to merge 3 commits intospring-projects:mainfrom
Closed
GH-4472 Fixed an issue in the mergeToolUseEvents method of StreamHelper#4474sunyuhan1998 wants to merge 3 commits intospring-projects:mainfrom
mergeToolUseEvents method of StreamHelper#4474sunyuhan1998 wants to merge 3 commits intospring-projects:mainfrom
Conversation
…hod in `StreamHelper` to enhance robustness when `previousEvent` is not a `ToolUseAggregationEvent`; 2. Fixed an issue in the `eventToChatCompletionResponse` method of `StreamHelper` where `thinkingBlock.signature()` was not being handled; 3. Improved `StreamHelperTests` to increase test coverage Signed-off-by: Sun Yuhan <sunyuhan1998@users.noreply.github.com>
Signed-off-by: Sun Yuhan <sunyuhan1998@users.noreply.github.com>
# Conflicts: # models/spring-ai-anthropic/src/test/java/org/springframework/ai/anthropic/api/StreamHelperTests.java
Member
|
@sunyuhan1998 Thanks for fixing this bug. |
Member
|
LGTM, rebased and merged as 9907b2c |
Member
|
Cherry-picked, and merged into 1.0.x as 6ced885 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in the issue, the current implementation of the
mergeToolUseEventsmethod inStreamHelperlacks robustness and does not properly handle cases wherepreviousEventis not of typeToolUseAggregationEvent. This PR addresses that issue.All the changes introduced by this PR:
mergeToolUseEventsmethod inStreamHelperto skip merging whenpreviousEventis not aToolUseAggregationEvent.StreamHelperTeststo improve test coverage.eventToChatCompletionResponsemethod inStreamHelperdid not handle thethinkingBlock.signature()property. This PR also fixes that issue.Fixes #4472