Handle Vertex AI tool call JsonProcessingException fallback#4521
Open
cho-thinkfree-com wants to merge 1 commit intospring-projects:mainfrom
Open
Handle Vertex AI tool call JsonProcessingException fallback#4521cho-thinkfree-com wants to merge 1 commit intospring-projects:mainfrom
cho-thinkfree-com wants to merge 1 commit intospring-projects:mainfrom
Conversation
Signed-off-by: cho-thinkfree-com <cho@thinkfree.com>
960654a to
3ad2acc
Compare
Contributor
Author
|
You can also address this by introducing a VertexAwareToolCallingManager that normalizes tool responses before they reach Vertex. The idea is simple:
This guarantees Vertex always receives a top-level JSON object. private static final class VertexAwareToolCallingManager implements ToolCallingManager {
private final DefaultToolCallingManager peerToolCallingManager;
public VertexAwareToolCallingManager(DefaultToolCallingManager peerToolCallingManager) {
this.peerToolCallingManager = peerToolCallingManager;
}
@Override
public ToolExecutionResult executeToolCalls(@NonNull Prompt prompt, @NonNull ChatResponse chatResponse) {
ToolExecutionResult res = this.peerToolCallingManager.executeToolCalls(prompt, chatResponse);
ObjectMapper om = safeObjectMapper();
var newHistory = res.conversationHistory().stream().map(msg -> {
if (msg instanceof ToolResponseMessage trm) {
var patched = trm.getResponses().stream().map(r -> {
String data = r.responseData();
// Normalizes to object JSON: returns {"result": data} when wrapping is required; otherwise returns data as is.
String normalized = normalizeToObjectJson(om, data);
return new ToolResponseMessage.ToolResponse(r.id(), r.name(), normalized);
}).toList();
return new ToolResponseMessage(patched);
}
return msg;
}).toList();
return new DefaultToolExecutionResult(newHistory, res.returnDirect());
}
//...
// ... |
|
what prevent this to be merging? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary