Skip to content

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Sep 30, 2025

Description
This PR adds comprehensive test coverage for the MilvusSearchRequest builder class, focusing on various parameter combinations and edge cases.

Changes
Added 7 new test methods to MilvusSearchRequestTest:

  • Single parameter tests: Verify builder behavior when setting only one parameter (query, topK, or similarity threshold) while others use defaults
  • Empty query handling: Ensures empty strings are handled correctly
  • Complex expressions: Tests storage of complex native Milvus expressions
  • JSON parameters: Validates complex search parameters JSON handling
  • Builder pattern behavior: Verifies that multiple calls to the same setter use the last value

Impact
The existing tests only covered basic scenarios with all parameters set. These new tests ensure the builder works correctly with partial configurations, validates default values are properly applied, and handles edge cases like empty queries and complex expressions.

Co-authored-by: Oleksandr Klymenko <[email protected]>
Signed-off-by: Oleksandr Klymenko <[email protected]>
@ilayaperumalg ilayaperumalg self-assigned this Oct 1, 2025
@ilayaperumalg ilayaperumalg added this to the 1.1.0.M3 milestone Oct 1, 2025
@ilayaperumalg
Copy link
Member

@alxkm Thanks for improving test coverage.

@ilayaperumalg
Copy link
Member

Rebased and merged as d016b10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants