test: add test coverage for MilvusSearchRequest builder#4523
Closed
alxkm wants to merge 1 commit intospring-projects:mainfrom
Closed
test: add test coverage for MilvusSearchRequest builder#4523alxkm wants to merge 1 commit intospring-projects:mainfrom
alxkm wants to merge 1 commit intospring-projects:mainfrom
Conversation
Co-authored-by: Oleksandr Klymenko <alexanderklmn@gmail.com> Signed-off-by: Oleksandr Klymenko <alexanderklmn@gmail.com>
Member
|
@alxkm Thanks for improving test coverage. |
Member
|
Rebased and merged as d016b10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds comprehensive test coverage for the
MilvusSearchRequestbuilder class, focusing on various parameter combinations and edge cases.Changes
Added 7 new test methods to
MilvusSearchRequestTest:Impact
The existing tests only covered basic scenarios with all parameters set. These new tests ensure the builder works correctly with partial configurations, validates default values are properly applied, and handles edge cases like empty queries and complex expressions.