Skip to content

Conversation

@ericbottard
Copy link
Member

Fixes #3243

Copy link
Member

@ilayaperumalg ilayaperumalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilayaperumalg ilayaperumalg added this to the 1.1.0.M4 milestone Oct 8, 2025
@ilayaperumalg ilayaperumalg self-assigned this Oct 9, 2025
@ilayaperumalg
Copy link
Member

Rebased and merged as 2ded9cd

@myifeng
Copy link

myifeng commented Dec 4, 2025

@ilayaperumalg @ericbottard

Could you please explain why List.of() is used here? Does this mean the content isn't being saved?

https://github.com/spring-projects/spring-ai/pull/4569/files#diff-2d8894a0ac637ab95a83efd64a5f280eaa3d34b3ca7101471c18df07bba2ea87R151

@ericbottard
Copy link
Member Author

The behavior has not changed and is explained by the comment above the line you referred to.

One could argue that the default value for the builder could be initialized to List.of() though.

@myifeng
Copy link

myifeng commented Dec 4, 2025

The behavior has not changed and is explained by the comment above the line you referred to.

One could argue that the default value for the builder could be initialized to List.of() though.

How can I save this value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants