Skip to content

Conversation

PabloSanchi
Copy link
Contributor

Add IBM watsonx.ai support

@PabloSanchi
Copy link
Contributor Author

This repo shows how to use it, In case it comes in handy: https://github.com/PabloSanchi/IBM-WatsonxAI-Spring-AI-Example

@tzolov
Copy link
Contributor

tzolov commented Mar 18, 2024

Hey @PabloSanchi , great contribution! Thanks.
I will review it shortly

@tzolov tzolov added this to the 1.0.0-M1 milestone Mar 18, 2024
@tzolov tzolov self-assigned this Mar 18, 2024
@tzolov tzolov added enhancement New feature or request model client labels Mar 18, 2024
@markpollack
Copy link
Member

Thanks so much for this. Will review and learn more about watstonx.ai!

@spring-projects spring-projects deleted a comment Mar 20, 2024
@tzolov
Copy link
Contributor

tzolov commented Mar 20, 2024

Additional pre-merge adjustments applied:

 - Rename all WatsonxAIXxx classes to WatsonxAiXxx.
 - Rename WatsonxChatClient to WatsonxAiChatClient.
 - Move WatsonxAiChatOptions out of the API.
 - Implement a Builder for WatsonxAiChatOptions (replace the inline withXxx code).
 - Add a WatsonxAiChatOptions field to WatsonxAiChatClient as default options.
   Later, it is also set by the auto-configuration properties.
 - Implement merging logic for default vs runtime options in WatsonxAiChatClient.
 - In Auto-config, add WatsonxAiChatProperties with enabled and options fields.
   Options are passed to the client.
 - Update the adoc to include the .chat.options properties.
 - Add the watsonxai doc to the nav.adoc.
 - Fix license headers and javadocs.
 - Move dependency versioning to the parent POM.

Then rebased, squashed and merged at 52d15f5

@tzolov tzolov closed this Mar 20, 2024
@tzolov
Copy link
Contributor

tzolov commented Mar 20, 2024

@PabloSanchi thank you again.
As you can see from the merge message i did some moderate changes to the code.
There are no ITs (because it is a SaaS i guess) and i have not had tried to run in it on the Watsonx platform, there are good chances that my changes have caused issues.
Please review them and if possible test on watsonx.ai.
Feel free to rase a follow up issues.

@PabloSanchi
Copy link
Contributor Author

@tzolov thank you for your time and consideration I appreciate it.
Perfect, I will check it as soon as possible and give feedback about the results :)

@PabloSanchi
Copy link
Contributor Author

@tzolov I tried and it works, I have updated the repo with the example usage. If you need credentials to test it, you can ask me for them, I can handle you some from a test environment I have on IBM Cloud :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request model client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants