Skip to content

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Oct 8, 2025

This PR adds additional test coverage for the MultiQueryExpander builder validation logic.

Changes

  • Added tests for valid prompt template configurations with both required placeholders
  • Added tests for prompt templates containing extra placeholders beyond the required ones
  • Added tests for builder behavior when properties are set multiple times
  • Added tests for null prompt template handling after setting a valid template
  • Added tests for case-sensitive placeholder validation

Test Coverage

These tests complement the existing validation tests by covering:

  • Positive cases: valid templates that should successfully build
  • Edge cases: templates with extra placeholders, builder property overrides
  • Negative cases: case-sensitivity of placeholder names

Validation

All tests follow the existing test patterns and use consistent assertions with the current test suite.

Co-authored-by: Oleksandr Klymenko <[email protected]>
Signed-off-by: Oleksandr Klymenko <[email protected]>
@ilayaperumalg ilayaperumalg added this to the 1.1.0.M4 milestone Oct 9, 2025
@ilayaperumalg
Copy link
Member

@alxkm Thanks for the PR and @sunyuhan1998 thanks for the review.

@ilayaperumalg ilayaperumalg self-assigned this Oct 9, 2025
@ilayaperumalg ilayaperumalg merged commit 26c803e into spring-projects:main Oct 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants