Skip to content

feat: Add support for URLs with query parameters in MimeTypeDetector #4616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

feat: Add support for URLs with query parameters in MimeTypeDetector #4616

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c51474
Add edge case and validation tests for MimeTypeDetector
alxkm Oct 12, 2025
1a7789d
Add support for URLs with query parameters in MimeTypeDetector
alxkm Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions ...ai-gemini/src/test/java/org/springframework/ai/vertexai/gemini/MimeTypeDetectorTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import java.nio.file.Path;
import java.util.stream.Stream;

import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
import org.junit.jupiter.params.provider.MethodSource;
Expand All @@ -30,6 +31,7 @@
import org.springframework.util.MimeType;

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.AssertionsForClassTypes.assertThatThrownBy;

/**
* @author YunKui Lu
Expand Down Expand Up @@ -90,4 +92,29 @@ void getMimeTypeByString(String extension, MimeType expectedMimeType) {
assertThat(mimeType).isEqualTo(expectedMimeType);
}

@Test
void getMimeTypeWithEmptyString() {
assertThatThrownBy(() -> MimeTypeDetector.getMimeType("")).isInstanceOf(IllegalArgumentException.class)
.hasMessageContaining("Unable to detect the MIME type");
}

@Test
void getMimeTypeWithMultipleDots() {
// Should use the last extension
MimeType expectedPng = MimeTypeDetector.GEMINI_MIME_TYPES.get("png");
assertThat(MimeTypeDetector.getMimeType("test.backup.png")).isEqualTo(expectedPng);
assertThat(MimeTypeDetector.getMimeType(new File("archive.tar.gz.png"))).isEqualTo(expectedPng);
}

@Test
void getMimeTypeWithQueryParameters() {
URI uri = URI.create("https://example.com/styles.css?version=1.2&cache=false");

assertThatThrownBy(() -> MimeTypeDetector.getMimeType(uri)).isInstanceOf(IllegalArgumentException.class)
.hasMessageContaining("Unable to detect the MIME type");

assertThatThrownBy(() -> MimeTypeDetector.getMimeType(uri.toURL())).isInstanceOf(IllegalArgumentException.class)
.hasMessageContaining("Unable to detect the MIME type");
}

}