Skip to content

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Oct 15, 2025

This PR adds null parameter validation tests for two components to ensure proper error handling at API boundaries.

Changes

AzureOpenAiRuntimeHints:

  • Added test verifying that registerHints() throws NullPointerException when RuntimeHints parameter is null
  • Ensures the method validates required parameters before processing

ResourceCacheService:

  • Added test verifying that getCachedResource() throws IllegalArgumentException when URI is null
  • Validates that error message contains "Location must not be null" for clear debugging
  • Prevents NullPointerException from bubbling up to callers

alxkm added 2 commits October 15, 2025 23:20
Co-authored-by: Oleksandr Klymenko <[email protected]>
Signed-off-by: Oleksandr Klymenko <[email protected]>
Co-authored-by: Oleksandr Klymenko <[email protected]>
Signed-off-by: Oleksandr Klymenko <[email protected]>
@ilayaperumalg ilayaperumalg added this to the 1.1.0.M4 milestone Oct 16, 2025
@ilayaperumalg
Copy link
Member

@alxkm Thanks for the PR! and @sunyuhan1998 Thanks for the review! Rebased and merged as c03a5ca

@ilayaperumalg ilayaperumalg self-assigned this Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants