Skip to content

Deprecate public constructor of QuestionAnswerAdvisor in favor of builder #4644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2025
+10 −2
Merged

Deprecate public constructor of QuestionAnswerAdvisor in favor of builder #4644

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions ...in/java/org/springframework/ai/chat/client/advisor/vectorstore/QuestionAnswerAdvisor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
* @author Timo Salm
* @author Ilayaperumal Gopinathan
* @author Thomas Vitale
* @author Yanming Zhou
* @since 1.0.0
*/
public class QuestionAnswerAdvisor implements BaseAdvisor {
Expand Down Expand Up @@ -82,6 +83,12 @@ public class QuestionAnswerAdvisor implements BaseAdvisor {

private final int order;

/**
* Construct instance by given VectorStore
* @param vectorStore the given VectorStore
* @deprecated in favor of {@link #builder(VectorStore)}}
*/
@Deprecated
public QuestionAnswerAdvisor(VectorStore vectorStore) {
this(vectorStore, SearchRequest.builder().build(), DEFAULT_PROMPT_TEMPLATE, BaseAdvisor.DEFAULT_SCHEDULER,
DEFAULT_ORDER);
Expand Down Expand Up @@ -122,8 +129,9 @@ public ChatClientRequest before(ChatClientRequest chatClientRequest, AdvisorChai
Map<String, Object> context = new HashMap<>(chatClientRequest.context());
context.put(RETRIEVED_DOCUMENTS, documents);

String documentContext = documents == null ? ""
: documents.stream().map(Document::getText).collect(Collectors.joining(System.lineSeparator()));
String documentContext = documents.stream()
.map(Document::getText)
.collect(Collectors.joining(System.lineSeparator()));

// 3. Augment the user prompt with the document context.
UserMessage userMessage = chatClientRequest.prompt().getUserMessage();
Expand Down